Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS safari returns to the previous page after entering the repository and there will be a js error #24784

Open
tyroneyeh opened this issue May 18, 2023 · 9 comments
Labels

Comments

@tyroneyeh
Copy link
Contributor

tyroneyeh commented May 18, 2023

Description

No response

Gitea Version

1.20.0+dev-833-g040970c32

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

IMG_9527

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

at try.gitea.io

Database

None

@liyimeng
Copy link

Likely the same in #24770

@wxiaoguang
Copy link
Contributor

Likely the same in #24770

24770 could be another problem IMO. That issue about "user randomly gets logged out".

I guess this issue is related to other problems if it keeps reproducing.

@liyimeng
Copy link

@wxiaoguang That would be bad. Why the good couple(gitea and safari) suddenly fall apart :)

@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 18, 2023

Apple also used to make new bugs (it could also be a bug on Gitea side)

If you google "safari blahblah", there are more bugs than Chrome.

@silverwind
Copy link
Member

I can attest, Safari is currently the most buggiest browser engine around, by a big margin.

@tyroneyeh
Copy link
Contributor Author

You can check that the error message is not displayed when the Safari browser is used

@silverwind
Copy link
Member

silverwind commented Jun 5, 2023

When testing with Simulator.app, I can reproduce the error but only when Safari Inspector is not attached. When attached, the error is never visible and all errors that I see are regarding source maps, which should be benign and not affect browsing.

image

So this needs some clear steps to reproduce, ideally with debugger attached.

lunny pushed a commit that referenced this issue Jun 6, 2023
…#25089)

- Enable all source maps in dev build
- Disable all source maps in prod build
- Provide `ENABLE_SOURCEMAP` env var to override it.

I think the strange error seen in
#24784 is sourcemap related, so
if we enable/disable them all, it might go away. But it's most
definitely a Safari bug.

With all sourcemaps disabled, binary size goes down by around 1-2 MB,
with all enabled it goes up by around 12MB. If +12MB is acceptable, we
could also always enable them by default as fully source maps do have
some debugging benefits.
@puni9869
Copy link
Member

Can we close this issue if it is done.

@silverwind
Copy link
Member

I don't think it's solved unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants