Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: can’t move anymore items between columns in kanban boards #24879

Closed
tobiasBora opened this issue May 23, 2023 · 6 comments · Fixed by #24892
Closed

Regression: can’t move anymore items between columns in kanban boards #24879

tobiasBora opened this issue May 23, 2023 · 6 comments · Fixed by #24892
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug

Comments

@tobiasBora
Copy link

Description

I don’t know why, but I realized today that on the https://gitea.com/ instance (1.20), I can’t move kanban items from one column to another while it used to work fine (which kind of defeats completely the purpose of kanban), see the gif in the screenshots section. I tried in both firefox (version 109.0.1) and chromium (version 109 as well).

Gitea Version

1.20

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Peek 23-05-2023 12-27

Git Version

No response

Operating System

No response

How are you running Gitea?

both try.gitea.io or https://gitea.com/

Database

None

@delvh
Copy link
Member

delvh commented May 23, 2023

@wxiaoguang gave me an idea here ↑ what went wrong:
@tobiasBora You mean on a repo-level project, right?
The PR @wxiaoguang mentioned changed the JS and the org-wide project templates, but as far as I know repo-level projects and org-level projects use different templates, so the repo-level projects were not changed to include the sortable class.

I can see two solutions:

  1. short-term: Add the check to the repo templates as well
  2. long-term: Merge the repo-and org-level templates into one.

@tobiasBora
Copy link
Author

Yeah, in a normal private repository created a while ago.

@silverwind silverwind added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label May 23, 2023
@yp05327
Copy link
Contributor

yp05327 commented May 24, 2023

@delvh
@wxiaoguang is right.
I'm sorry, I forgot to edit the repo-level projects template in #24589.
Will be fixed in #24892.

@yp05327
Copy link
Contributor

yp05327 commented May 24, 2023

I agree Merge the repo-and org-level templates into one.
It doesn't look good now that we have to maintain both repo- and org-level templates, they have almost same codes.

lunny pushed a commit that referenced this issue May 24, 2023
Fix #24879
Related to #24589

In #24589, I changed the css, but didn't reflect the changes in
repo-level projects template.
@tobiasBora
Copy link
Author

tobiasBora commented May 24, 2023

Awesome! Any idea when this will be deployed to gitea.org?

@lunny
Copy link
Member

lunny commented May 24, 2023

gitea.com updated.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 24, 2023
brechtvl pushed a commit to blender/gitea that referenced this issue May 31, 2023
Fix go-gitea#24879
Related to go-gitea#24589

In go-gitea#24589, I changed the css, but didn't reflect the changes in
repo-level projects template.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants