Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo's default branch when adding new files in an empty one #25017

Merged
merged 1 commit into from May 31, 2023
Merged

Update repo's default branch when adding new files in an empty one #25017

merged 1 commit into from May 31, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 31, 2023 •
edited

Fix #25014

Only API needs this fix. On the Web UI, users could only add new file on the default branch.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2023
@wxiaoguang wxiaoguang mentioned this pull request May 31, 2023
Closed
@wxiaoguang wxiaoguang added this to the 1.20.0 milestone May 31, 2023
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 31, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 31, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 31, 2023
@lunny lunny merged commit a90988d into go-gitea:main May 31, 2023
21 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 31, 2023
@wxiaoguang wxiaoguang deleted the fix-empty-repo branch May 31, 2023 09:15
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 1, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
f691fbe 
* upstream/main:
  Fix users cannot visit issue attachment bug (go-gitea#25019)
  Fix incorrect issuel filter menu style (go-gitea#25018)
  Update repo's default branch when adding new files in an empty one (go-gitea#25017)
  Rename NotifyPullReviewRequest to NotifyPullRequestReviewRequest (go-gitea#24988)
  Merge `new project` templates into one (go-gitea#24985)
  Add chinese documentations for `cran package registry` (go-gitea#25012)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Upload a new file to an empty repo by API will not update repo's default branch
4 participants
@wxiaoguang @lunny @delvh @GiteaBot