Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect issuel filter menu style #25018

Merged
merged 1 commit into from May 31, 2023
Merged

Fix incorrect issuel filter menu style #25018

merged 1 commit into from May 31, 2023

Conversation

wxiaoguang
Copy link
Contributor

Before:

image

After:

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2023
@wxiaoguang wxiaoguang mentioned this pull request May 31, 2023
Merged
@wxiaoguang wxiaoguang added this to the 1.20.0 milestone May 31, 2023
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 31, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 31, 2023
silverwind
silverwind approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously this was colored, but I guess this fits better into the overall UI design now.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 31, 2023
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented May 31, 2023 •
edited

Yup, in old releases the "active" items are set to "primary / green / blue" colors, and at that time many elements have that eye-catching colors.

Then most unnecessary eye-catching colors are removed (set to grey, etc), so I also agree this soft "active" color fits better.

@silverwind silverwind merged commit 48bfea6 into go-gitea:main May 31, 2023
21 checks passed
@wxiaoguang wxiaoguang deleted the fix-issue-menu branch May 31, 2023 10:44
@silverwind
Copy link
Member

Sorry, might have merged a bit too soon here, but the active merge button was just too tempting.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 1, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
f691fbe 
* upstream/main:
  Fix users cannot visit issue attachment bug (go-gitea#25019)
  Fix incorrect issuel filter menu style (go-gitea#25018)
  Update repo's default branch when adding new files in an empty one (go-gitea#25017)
  Rename NotifyPullReviewRequest to NotifyPullRequestReviewRequest (go-gitea#24988)
  Merge `new project` templates into one (go-gitea#24985)
  Add chinese documentations for `cran package registry` (go-gitea#25012)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoguang @silverwind @lunny @GiteaBot