Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling dismissing a review could cause strange UI behavior #25130

Closed
wolfogre opened this issue Jun 8, 2023 · 0 comments · Fixed by #25133
Closed

Cancelling dismissing a review could cause strange UI behavior #25130

wolfogre opened this issue Jun 8, 2023 · 0 comments · Fixed by #25133
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.20.0

Comments

@wolfogre
Copy link
Member

wolfogre commented Jun 8, 2023

Description

Screen.Recording.2023-06-08.at.12.29.38.mov

Gitea Version

1.20.0+dev-999-g8d7893e81

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

On gitea.com

Database

None
@wolfogre wolfogre added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 8, 2023
@lunny lunny added this to the 1.20.0 milestone Jun 8, 2023
@yp05327 yp05327 mentioned this issue Jun 8, 2023
Merged
silverwind pushed a commit that referenced this issue Jun 8, 2023
@yp05327
Fix strange UI behavior of cancelling dismiss review modal (#25133)
b5a2bb9 
Fixes #25130

The old code uses `$(this).next()` to get `dismiss-review-modal`.
At first, it will get `$(#dismiss-review-modal)`, but the next time it
will get `$(#dismiss-review-modal).next();`
and then `$(#dismiss-review-modal).next().next();`.
Because div `dismiss-review-modal` will be removed when
`dismiss-review-btn` clicked.

Maybe the right usage is adding `show-modal` class and `data-modal`
attribute.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jun 8, 2023
@yp05327 @GiteaBot
Fix strange UI behavior of cancelling dismiss review modal (go-gitea#…
be1bd97 
…25133)

Fixes go-gitea#25130

The old code uses `$(this).next()` to get `dismiss-review-modal`.
At first, it will get `$(#dismiss-review-modal)`, but the next time it
will get `$(#dismiss-review-modal).next();`
and then `$(#dismiss-review-modal).next().next();`.
Because div `dismiss-review-modal` will be removed when
`dismiss-review-btn` clicked.

Maybe the right usage is adding `show-modal` class and `data-modal`
attribute.
@GiteaBot GiteaBot mentioned this issue Jun 8, 2023
Closed
silverwind pushed a commit to silverwind/gitea that referenced this issue Jun 9, 2023
@yp05327 @silverwind
Fix strange UI behavior of cancelling dismiss review modal (go-gitea#…
d30aae5 
…25133)

Fixes go-gitea#25130

The old code uses `$(this).next()` to get `dismiss-review-modal`.
At first, it will get `$(#dismiss-review-modal)`, but the next time it
will get `$(#dismiss-review-modal).next();`
and then `$(#dismiss-review-modal).next().next();`.
Because div `dismiss-review-modal` will be removed when
`dismiss-review-btn` clicked.

Maybe the right usage is adding `show-modal` class and `data-modal`
attribute.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Fix strange UI behavior of cancelling dismiss review modal yp05327/gitea
2 participants
@lunny @wolfogre