Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification page update wrong page #25627

Closed
bauermarkus opened this issue Jul 2, 2023 · 1 comment · Fixed by #25781
Closed

Notification page update wrong page #25627

bauermarkus opened this issue Jul 2, 2023 · 1 comment · Fixed by #25781
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.20.0

Comments

@bauermarkus
Copy link

Description

When you have multiple pages of notifications and you open a notification in a new tab with page greater 1, the auto update of the notification page will push you back to page 1, even the URL still tells you the original page (greater 1).

Gitea Version

1.20.0-rc1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker

Database

SQLite
@wxiaoguang
Copy link
Contributor

There is a bug in updateNotificationTable .....

@wxiaoguang wxiaoguang added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jul 2, 2023
@wxiaoguang wxiaoguang modified the milestones: 1.21.0, 1.20.0 Jul 2, 2023
@wxiaoguang wxiaoguang mentioned this issue Jul 9, 2023
Merged
silverwind pushed a commit that referenced this issue Jul 9, 2023
@wxiaoguang
Fix notification list bugs (#25781)
84c7865 
Fix #25627

1. `ctx.Data["Link"]` should use relative URL but not AppURL
2. The `data-params` is incorrect because it doesn't contain "page". JS
can simply use "window.location.search" to construct the AJAX URL
3. The `data-xxx` and `id` in notification_subscriptions.tmpl were
copied&pasted, they don't have affect.
@GiteaBot GiteaBot mentioned this issue Jul 9, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jul 9, 2023
@wxiaoguang @GiteaBot
Fix notification list bugs (go-gitea#25781)
2677cbd 
Fix go-gitea#25627

1. `ctx.Data["Link"]` should use relative URL but not AppURL
2. The `data-params` is incorrect because it doesn't contain "page". JS
can simply use "window.location.search" to construct the AJAX URL
3. The `data-xxx` and `id` in notification_subscriptions.tmpl were
copied&pasted, they don't have affect.
silverwind pushed a commit that referenced this issue Jul 9, 2023
@GiteaBot @wxiaoguang
Fix notification list bugs (#25781) (#25787)
a5a3c81 
Backport #25781 by @wxiaoguang

Fix #25627

1. `ctx.Data["Link"]` should use relative URL but not AppURL
2. The `data-params` is incorrect because it doesn't contain "page". JS
can simply use "window.location.search" to construct the AJAX URL
3. The `data-xxx` and `id` in notification_subscriptions.tmpl were
copied&pasted, they don't have affect.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Fix notification list bugs wxiaoguang/gitea
2 participants
@wxiaoguang @bauermarkus