Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commits table regression #25710

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Fix commits table regression #25710

merged 4 commits into from
Jul 6, 2023

Conversation

denyskon
Copy link
Member

@denyskon denyskon commented Jul 5, 2023

Fixes #25693

The commits table appearance fix in #25634 was incomplete and caused a regression. This PR fixes that issue and removes some unneeded CSS classes because of the proper fix.

Before

Bildschirmfoto vom 2023-07-05 19-37-04
Bildschirmfoto vom 2023-07-05 19-38-56

After

Bildschirmfoto vom 2023-07-05 19-37-44
Bildschirmfoto vom 2023-07-05 19-38-08

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 5, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 5, 2023
@denyskon denyskon changed the title Fix commits table Fix commits table regression Jul 5, 2023
@denyskon denyskon added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 5, 2023
silverwind
silverwind reviewed Jul 5, 2023
View reviewed changes
web_src/css/repo.css Outdated Show resolved Hide resolved
@silverwind
Copy link
Member

Still overflows for me with long commit messages. Please also remove the white-space: nowrap, we need to let these wrap:

Screenshot 2023-07-05 at 20 40 11

@denyskon
Copy link
Member Author

denyskon commented Jul 5, 2023

It does work on my machine in Firefox and in Chrome... I wonder what the difference is. I explicitly set white-space: normal for the commit message

@denyskon
Copy link
Member Author

denyskon commented Jul 5, 2023

Updated to use .repository #commits-table td:not(.message)

Bildschirmfoto vom 2023-07-05 20-53-03

@silverwind
Copy link
Member

Need to re-check, I now see the previous code also had nowrap, so I was wrongly assuming it was introduced by this PR. Generally for UI testing you should test with content like xxxxxxxxxxx, e.g. long strings of unbroken text, this will bring out any wrapping-related issues. Often, you can also just edit the DOM on the file in the devtools.

@silverwind
Copy link
Member

The non-wrap issue in also present in main branch. I will try to come up with a fix

@silverwind
Copy link
Member

Turns out only overflow-wrap: anywhere was needed to get the unbroken line to wrap. We should later evaluate adding this on a global level, as I think there are no downsides to it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 6, 2023
@denyskon denyskon mentioned this pull request Jul 6, 2023
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 6, 2023
@6543 6543 merged commit 753755b into go-gitea:main Jul 6, 2023
23 checks passed
@GiteaBot GiteaBot added this to the 1.21.0 milestone Jul 6, 2023
@denyskon denyskon deleted the fix/commits-table branch July 6, 2023 21:08
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 7, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
55bdbdd 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Remove unused code (go-gitea#25734)
  Fix commits table regression (go-gitea#25710)
  Fix inconsistent user profile layout across tabs (go-gitea#25625)
  Simplify the LFS GC logger usage (go-gitea#25717)
  Allow/fix review (approve/reject) of empty PRs (go-gitea#25690)
  Correct permissions for `.ssh` and `authorized_keys` (go-gitea#25721)
  Sync branches when mirroring (go-gitea#25722)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@6543 6543 6543 approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

commits history page style error
4 participants
@denyskon @silverwind @6543 @GiteaBot