Unable to Create Pull Request in Forked Repo

[SoulSeekkor]

Description

Unable to test this on the demo site since you can't create orgs on it.

I have an organization on my Gitea (Bitwarden) which as the server repo which is a mirror of the repo on GitHub. I have forked that repo to my user and that's where I create modified branches and things to test with. Before I go to create a new modified branch I create a new pull request to pull changes in from the mirror to my fork... With 1.20.1 this is broken and only lets me pull changes from the repo into itself (and doesn't let me choose the source repo that the repo was forked from).

Gitea Version

1.20.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

2.40.1

Operating System

Ubuntu 18.04.6 LTS

How are you running Gitea?

Binary download from release ran as a service with systemd.

Database

MySQL

[CaiCandong]

Can you give me detailed steps to reproduce this bug?

[SoulSeekkor]

Sure! So on my instance I have the following repo mirrored:
https://github.com/bitwarden/server

Then fork that repo to your personal user as the owner. Try to create a new Pull Request on your forked repo and (for me at least) the pull into and pull from will both be only your personal forked repo with no ability to change the pull from to be that mirrored repo (which I've been able to do in the past and is a necessary action).

[CaiCandong]

I don't quite understand what you mean, I tried following your tips and my tests resulted in being able to create PRs.

[SoulSeekkor]

Okay, so now fork that mirror you created. On that fork try to create a PR to pull in changes from the local mirror, the only option you should see on the pull from dropdown is the fork itself making the PR unusable.

[CaiCandong]

I'm sorry I still can't reproduce the problem you're talking about, are you able to provide a video showing the problem you're talking about?

[SoulSeekkor]

I can see about a video potentially, never had to make one so I will have to get something to do that. But in the meantime here's a step-by-step that hopefully allows you to reproduce the problem:

1. Create a new org called 'Test' (name doesn't matter, take defaults).
2. Create a new migration from GitHub of the following repo (https://github.com/MysticRyuujin/guac-install.git) with the new org you created in step 1 as the owner, take defaults but mark it as a mirror.
3. After the migration is complete, fork this repo with your user as the owner, take defaults.
4. Create a PR on this forked repo, note that the merge into and pull from are the same, making it useless. Typing in 'main' for the branch to attempt to display the main branch from the source mirror repo (have had to do this on older Gitea) yields nothing but the current forked repo still.

[Jaffex]

Possible duplicate of #24585

[yp05327]

It seems that you want to create a pr to a mirror repo?
If you access the mirror repo, you can see that there's no PR unit. So of cause you can not select the main branch of this mirror repo.

Wait. In this mirror repo's setting, PR unit is enabled. Can we create PRs in a mirror repo?

[Jaffex]

I think the issue here is that we're unable to create a pull request from the mirror repo, less so to the mirror repo.

[SoulSeekkor]

I think the issue here is that we're unable to create a pull request from the mirror repo, less so to the mirror repo.

This! We used to be able to, according to the linked issue above it appears this broke in a dot fix for 1.19 (I haven't done it for a while).

[catfromplan9]

it broke when i updated to latest gitea, please fix

[CaiCandong]

Fixed by #26785