New pushed branches show up after migration

[yardenshoham]

Description

Gitea Version

4244ce0 (current main)

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Gitpod

Database

SQLite

[lunny]

So, pull mirrors and migrated repositories should not prompt the branches pushed.

[lunny]

For migrated repositories, it's difficult to say the prompt is wrong.

[cassiozareck]

May the error lies in the fact unix times aren't being preserved at the database?

This is the exact time the migration was made, not the original time the push was made at the original repo. So perhaps this is why FindRecentlyPushedNewBranches is considerating it

[Zettat123]

In my opinion,

• for mirror repos, we should not show the prompt
• for the repos with pull request units disabled, we should not show the prompt
• for migrated repositories, I think we can keep the prompt as it might be useful sometimes

[yardenshoham]

Agree with the first 2.

In migrated repositories, don't show it until the first commit after the migration

[Zettat123]

May the error lies in the fact unix times aren't being preserved at the database?

This is the exact time the migration was made, not the original time the push was made at the original repo. So perhaps this is why `FindRecentlyPushedNewBranches` is considerating it

Yes, the created_unix is the time when create the record. Maybe we should check commit_time in FindRecentlyPushedNewBranches

[lunny]

May the error lies in the fact unix times aren't being preserved at the database?

This is the exact time the migration was made, not the original time the push was made at the original repo. So perhaps this is why FindRecentlyPushedNewBranches is considerating it

Yes, the created_unix is the time when create the record. Maybe we should check commit_time in FindRecentlyPushedNewBranches

Yes, we should use commit_time really.

[Zettat123]

In my opinion,

• for mirror repos, we should not show the prompt
• for the repos with pull request units disabled, we should not show the prompt
• for migrated repositories, I think we can keep the prompt as it might be useful sometimes

By using commit_time, only prompts of newly pushed branches will be displayed for migrated repos. I think it could help solve this issue.