Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide navbar when only 1 sign-in method is available (#2444) #2648

Merged
merged 3 commits into from
Oct 4, 2017
Merged

hide navbar when only 1 sign-in method is available (#2444) #2648

merged 3 commits into from
Oct 4, 2017

Conversation

kaz
Copy link
Contributor

@kaz kaz commented Oct 4, 2017

this was suggested in #2444
closes #2444

@codecov-io
Copy link

codecov-io commented Oct 4, 2017 •
edited
Loading

Codecov Report

Merging #2648 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2648   +/-   ##
=======================================
  Coverage   27.12%   27.12%           
=======================================
  Files          86       86           
  Lines       17064    17064           
=======================================
  Hits         4629     4629           
  Misses      11757    11757           
  Partials      678      678

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79af9c...409bebb. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 4, 2017
@lafriks
Copy link
Member

lafriks commented Oct 4, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 4, 2017
@daviian
Copy link
Member

daviian commented Oct 4, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2017
@lafriks lafriks merged commit fcca037 into go-gitea:master Oct 4, 2017
@lafriks lafriks added this to the 1.3.0 milestone Oct 4, 2017
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality labels Oct 4, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

'Sign in' Page improvement
5 participants
@kaz @codecov-io @lafriks @daviian @tboerger