Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron action incorrectly updates commit status of last commit #26971

Closed
silverwind opened this issue Sep 8, 2023 · 1 comment · Fixed by #26975
Closed

Cron action incorrectly updates commit status of last commit #26971

silverwind opened this issue Sep 8, 2023 · 1 comment · Fixed by #26975
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Milestone
1.21.0

Comments

@silverwind
Copy link
Member

silverwind commented Sep 8, 2023 •
edited

Description

Workflow: https://gitea.com/gitea/gitea-docusaurus/src/branch/main/.gitea/workflows/build-and-publish.yaml
Commit: https://gitea.com/gitea/gitea-docusaurus/commit/d3697c65d25e763ff9f36d1db1888610612ec0b5

Initially, the action ran as part of a push to the main branch and passed. Then the cron action ran on scheduled time, failed, but updated the commit status of the commit in the main branch which is incorrect. Cron actions should not update any commit status as they run disassociated from commits, so their results should only be visible in the actions log.

Gitea Version

main
@silverwind silverwind added type/bug topic/gitea-actions related to the actions of Gitea labels Sep 8, 2023
@lunny
Copy link
Member

lunny commented Sep 8, 2023

Maybe we should remove these lines. https://github.com/go-gitea/gitea/blob/main/services/actions/schedule_tasks.go#L136

@lunny lunny added this to the 1.21.0 milestone Sep 8, 2023
@lunny lunny mentioned this issue Sep 8, 2023
Merged
lunny added a commit that referenced this issue Sep 8, 2023
@lunny
Add a new column schedule_id for action_run to track (#26975)
9c0a353 
Fix #26971 

And the UI now will display it's scheduled but not triggered by a push.

<img width="954" alt="图片"
src="https://github.com/go-gitea/gitea/assets/81045/d211845c-457e-4c3e-af1f-a0d654d3f365">
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Milestone
1.21.0
Development

Successfully merging a pull request may close this issue.

Add a new column schedule_id for action_run to track lunny/gitea
2 participants
@lunny @silverwind