Support for grouping RPMs using paths #26984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
GiteaBot
added
the
pr/breaking
github-actions
bot
added
the
type/docs
ExplodingDragon
changed the title
ExplodingDragon
force-pushed
the
feature-support-multi-rpm-dist
branch
from
3f4a184
to
4ced55f
Compare
…Dragon/gitea into feature-support-multi-rpm-dist
lunny
approved these changes
Sep 11, 2023
GiteaBot
added
lgtm/need 1
github-actions
bot
added
modifies/api
|
@KN4CK3R After a period of use, this PR is ready to begin reviewing. |
lafriks
approved these changes
Jan 12, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
There are some flaws I created a fix-PR for this PR but forgot to block this one, sorry. I will send the fix as a new PR. |
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
The current rpm repository places all packages in the same repository, and different systems (el7,f34) may hit packages that do not belong to this distribution ( go-gitea#25304 ) , which now supports grouping of rpm.  Fixes go-gitea#25304 . Fixes go-gitea#27056 . Refactor: [go-gitea#25866](go-gitea#25866)
lafriks
pushed a commit
that referenced
this pull request
Jan 19, 2024
Related #26984 (#26984 (comment)) Fix admin cleanup message. Fix models `Get` not respecting default values. Rebuild RPM repository files after cleanup. Do not add RPM group to package version name. Force stable sorting of Alpine/Debian/RPM repository data. Fix missing deferred `Close`. Add tests for multiple RPM groups. Removed non-cached `ReplaceAllStringRegex`. If there are multiple groups available, it's stated in the package installation screen: 
henrygoodman
pushed a commit
to henrygoodman/gitea
that referenced
this pull request
Jan 31, 2024
Related go-gitea#26984 (go-gitea#26984 (comment)) Fix admin cleanup message. Fix models `Get` not respecting default values. Rebuild RPM repository files after cleanup. Do not add RPM group to package version name. Force stable sorting of Alpine/Debian/RPM repository data. Fix missing deferred `Close`. Add tests for multiple RPM groups. Removed non-cached `ReplaceAllStringRegex`. If there are multiple groups available, it's stated in the package installation screen: 
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
The current rpm repository places all packages in the same repository, and different systems (el7,f34) may hit packages that do not belong to this distribution ( go-gitea#25304 ) , which now supports grouping of rpm.  Fixes go-gitea#25304 . Fixes go-gitea#27056 . Refactor: [go-gitea#25866](go-gitea#25866)
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Related go-gitea#26984 (go-gitea#26984 (comment)) Fix admin cleanup message. Fix models `Get` not respecting default values. Rebuild RPM repository files after cleanup. Do not add RPM group to package version name. Force stable sorting of Alpine/Debian/RPM repository data. Fix missing deferred `Close`. Add tests for multiple RPM groups. Removed non-cached `ReplaceAllStringRegex`. If there are multiple groups available, it's stated in the package installation screen: 
|
Erm… Why did Giteabot mark the PR as breaking? |
delvh
removed
the
pr/breaking
|
Okay, I found out the cause: According to the original description, the PR was breaking. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current rpm repository places all packages in the same repository, and different systems (el7,f34) may hit packages that do not belong to this distribution ( #25304 ) , which now supports grouping of rpm.
Fixes #25304 .
Fixes #27056 .
Refactor: #25866