Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update snap package #27021

Merged
merged 4 commits into from
Sep 12, 2023
Merged

update snap package #27021

merged 4 commits into from
Sep 12, 2023

Conversation

siennathesane
Copy link
Contributor

@siennathesane siennathesane commented Sep 11, 2023 •
edited

update snapcraft wrapper to use core22 as the current lts and all of the build & deploy deps for snap

relates to #27014

@siennathesane
update snap for git >=2.29.0 for proc-receive hook
ebd60fb 
Signed-off-by: Sienna Lloyd <sienna@linux.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 11, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2023
@siennathesane siennathesane mentioned this pull request Sep 11, 2023
Closed
silverwind
silverwind reviewed Sep 11, 2023
View reviewed changes
snap/snapcraft.yaml Outdated Show resolved Hide resolved
silverwind
silverwind reviewed Sep 11, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
siennathesane and others added 2 commits September 11, 2023 11:02
@siennathesane @silverwind
locked go version
355d3f5 
Co-authored-by: silverwind <me@silverwind.io>
@siennathesane
updated .gitignore to optimize snap generated files
9c3e882 
Signed-off-by: Sienna Lloyd <sienna@linux.com>
techknowlogick
techknowlogick approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, and for the one to tea too :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 11, 2023
@techknowlogick techknowlogick added the topic/distribution This PR changes something about the packaging of Gitea label Sep 11, 2023
@silverwind
Copy link
Member

Should we upgrade to node 20? @techknowlogick I noticed you reverted to node 18, any reason?

@techknowlogick
Copy link
Member

@silverwind yeah, the snap builder doesn't like 20 (for our project at least). I've found that I have to keep it a few versions behind. It's hard to debug because it only pulls the config from the main branch, and it builds fine locally just not in the remote runner.
Maybe we switch from the remote runner to Actions, but from past attempts that's tricky building for multi-arch snaps.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 12, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) September 12, 2023 12:46
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 12, 2023
@techknowlogick techknowlogick merged commit e986265 into go-gitea:main Sep 12, 2023
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Sep 12, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 12, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 13, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8251797 
* giteaofficial/main:
  fix media description render for orgmode (go-gitea#26895)
  Show OpenID Connect and OAuth on signup page (go-gitea#20242)
  Update status and code index after changing the default branch (go-gitea#27018)
  add sparse url in cargo package guide (go-gitea#26937)
  Add missing 404 response to Swagger (go-gitea#27038)
  Fix object storage path handling (go-gitea#27024)
  [skip ci] Updated translations via Crowdin
  bump rootful to 16gb
  setup go in the nightly release pipeline
  Speed up nightly builds (go-gitea#27045)
  Improve repo/user/org search  (go-gitea#27030)
  Use Actuated.dev runner for nightly builds
  update snap package (go-gitea#27021)
  resolve issue with sort icons on admin/users and admin/runners (go-gitea#24360)
@delvh delvh modified the milestones: 1.22.0, 1.21.0 Sep 13, 2023
@denyskon denyskon added type/dependency-update topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile and removed type/dependency-update labels Nov 13, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/distribution This PR changes something about the packaging of Gitea
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@siennathesane @silverwind @techknowlogick @GiteaBot @denyskon @delvh