Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean some functions about project issue #27705

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Clean some functions about project issue #27705

merged 1 commit into from
Oct 20, 2023

Conversation

lng2020
Copy link
Member

@lng2020 lng2020 commented Oct 20, 2023

  1. remove unused function MoveIssueAcrossProjectBoards
  2. extract the project board condition into a function
  3. use db.NoCondition instead of -1. (BTW, the usage of db.NoCondition is too confusing. Is there any way to avoid that?)
  4. remove the unnecessary comment since the ctx refactor is completed.
  5. Change b.ID != 0 to b.ID > 0. It's more intuitive but I think they're the same since board ID can't be negative.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 20, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2023
delvh
delvh approved these changes Oct 20, 2023
View reviewed changes
models/issues/issue_project.go Show resolved Hide resolved
models/issues/issue_project.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 20, 2023
@delvh delvh added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 20, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2023
@6543 6543 added this to the 1.22.0 milestone Oct 20, 2023
@6543 6543 merged commit eb14787 into go-gitea:main Oct 20, 2023
25 checks passed
@6543 6543 mentioned this pull request Oct 20, 2023
Closed
@lng2020 lng2020 deleted the clean_func branch October 21, 2023 03:16
@BaiZe1998 BaiZe1998 mentioned this pull request Oct 21, 2023
Open
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 23, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
ea65a8c 
* upstream/main:
  Fix incorrect ctx usage in defer function (go-gitea#27740)
  Enable followCursor for language stats bar (go-gitea#27713)
  teams: new View button (go-gitea#27685)
  fix issues in translation file (go-gitea#27699)
  Fix an indentation in the Chinese documentation of Act Runner (go-gitea#27730)
  [skip ci] Updated translations via Crowdin
  Fix org team endpoint (go-gitea#27721)
  Improve diff tree spacing (go-gitea#27714)
  refactor: make db iterate context aware (go-gitea#27710)
  [FIX] resolve confusing colors in languages stats by insert a gap (go-gitea#27704)
  Fix sticky diff header background (go-gitea#27697)
  Replace -1 with GhostUserID (go-gitea#27703)
  Clean some functions about project issue (go-gitea#27705)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lng2020 @6543 @delvh @GiteaBot