teams: new View button #27685
teams: new View button #27685
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
|
I think the button here would be best changed to "View". Because this team information page can be viewed by all members of the organization, but only some members with permissions can modify team information and add members on this team information page. |
pull-request-size
bot
added
size/M
github-actions
bot
added
modifies/translation
and removed
modifies/templates
Thanks @Sonic853 for the feedback. edit: per feedback from @lunny, I have removed the translations for other languages and only included English |
tomholford
force-pushed
the
th/add-team-member-button
branch
from
0319cb2
to
1db8e56
Compare
pull-request-size
bot
added
size/XS
tomholford
force-pushed
the
th/add-team-member-button
branch
from
1db8e56
to
571d3d1
Compare
templates/org/team/teams.tmpl
Outdated
| @@ -16,6 +16,7 @@ | |||
| <div class="ui top attached header"> | |||
| <a class="text black" href="{{$.OrgLink}}/teams/{{.LowerName | PathEscape}}"><strong>{{.Name}}</strong></a> | |||
| <div class="ui right"> | |||
| <a class="btn ui primary small button" href="{{$.OrgLink}}/teams/{{.LowerName | PathEscape}}">{{ctx.Locale.Tr "org.teams.view"}}</a> | |||
There was a problem hiding this comment.
There is an exactly same link above: <a class="text black" href="{{$.OrgLink}}/teams/{{.LowerName | PathEscape}}">
Why duplicate?
Ideally, either make the existing link more obvious/intuitive (eg: add an icon, or a symbol), or remove the old link, only use the new link.
(just my opinion, not a blocker)
There was a problem hiding this comment.
@wxiaoguang In the linked issue (#22054), multiple users (including myself) didn't realize that the title of the group is also a link. It's only visible on hover. I am not opposed to removing the link. The purpose of this PR is to make it more obvious. Will defer to you, @lunny and @Sonic853 on whether or not we should keep the link in the title.
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/blocked
Per the discussion on go-gitea#22054, the flow for adding a new team mamber is not intuitive for new Gitea users. The ideal solution would be to add a new button on the Org > Members index view (see the screenshot mockup in the issue description). However, this would require a refactor of the UX for the flow. The current flow has an implicit context of which team within the org the new member is being added to. From the Members index, there is no implicit context; the flow would have to add a picker for which team the new member should be added to. So, as a stopgap, this change simply adds a button to the Teams index page that performs the same action as clicking on the title of the team (a behavior that is currently too obscure as indicated in the comments on the issue). This should reduce support burden and serve as a decent temporary measure until the Add Member flow is refactored.
tomholford
force-pushed
the
th/add-team-member-button
branch
from
02dbec3
to
b280cf6
Compare
|
@silverwind @wxiaoguang Thanks for the feedback. I have addressed both requested changes in the latest commit. |
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
* upstream/main: Fix incorrect ctx usage in defer function (go-gitea#27740) Enable followCursor for language stats bar (go-gitea#27713) teams: new View button (go-gitea#27685) fix issues in translation file (go-gitea#27699) Fix an indentation in the Chinese documentation of Act Runner (go-gitea#27730) [skip ci] Updated translations via Crowdin Fix org team endpoint (go-gitea#27721) Improve diff tree spacing (go-gitea#27714) refactor: make db iterate context aware (go-gitea#27710) [FIX] resolve confusing colors in languages stats by insert a gap (go-gitea#27704) Fix sticky diff header background (go-gitea#27697) Replace -1 with GhostUserID (go-gitea#27703) Clean some functions about project issue (go-gitea#27705)
Per the discussion on go-gitea#22054, the flow for adding a new team member to an org is not intuitive for new Gitea users. The ideal solution would be to add a new button on the Org > Members index view (see the screenshot mockup in the issue description). However, this would require a refactor of the UX for the flow. The current flow has an implicit context of which team within the org the new member is being added to ('Owners' by default). From the Members index, there is no implicit context; the flow would have to add a picker for which team the new member should be added to. So, as a stopgap, this change simply adds a button to the Teams index page that performs the same action as clicking on the title of the team (a behavior that is currently too obscure as indicated in the comments on the issue). This should reduce support burden and serve as a decent temporary measure until the Add Member flow is refactored. --------- Co-authored-by: tomholford <tomholford@users.noreply.github.com>
Per the discussion on #22054, the flow for adding a new team member to an org is not intuitive for new Gitea users.
The ideal solution would be to add a new button on the Org > Members index view (see the screenshot mockup in the issue description). However, this would require a refactor of the UX for the flow. The current flow has an implicit context of which team within the org the new member is being added to ('Owners' by default). From the Members index, there is no implicit context; the flow would have to add a picker for which team the new member should be added to.
So, as a stopgap, this change simply adds a button to the Teams index page that performs the same action as clicking on the title of the team (a behavior that is currently too obscure as indicated in the comments on the issue). This should reduce support burden and serve as a decent temporary measure until the Add Member flow is refactored.