Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to golangci-lint@v1.55.0 #27756

Merged
merged 11 commits into from Oct 24, 2023
Merged

Upgrade to golangci-lint@v1.55.0 #27756

merged 11 commits into from Oct 24, 2023

Conversation

silverwind
Copy link
Member

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 23, 2023
@silverwind
Copy link
Member Author

silverwind commented Oct 23, 2023 •
edited

Two new error types, shouldn't be hard to fix:

  • indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
  • dot-imports: should not use dot imports (revive)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2023
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Oct 23, 2023
@silverwind
Copy link
Member Author

indent-error-flow should be all fixed, for dot-imports I will wait on another CI run to show me the errors.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2023
@silverwind
Copy link
Member Author

Compile error was caused by rather strange decision from revive to flag if branches that depends on variables declared in the if declaration.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2023
@lunny lunny enabled auto-merge (squash) October 24, 2023 01:44
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 24, 2023
@lunny lunny merged commit ce83609 into go-gitea:main Oct 24, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 24, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 24, 2023
@silverwind silverwind deleted the golangci155 branch October 24, 2023 06:08
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 24, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
356b2f4 
* giteaofficial/main:
  Do not force creation of _cargo-index repo on publish (go-gitea#27266)
  Upgrade to golangci-lint@v1.55.0 (go-gitea#27756)
  Fix incorrect "tab" parameter for repo search sub-template (go-gitea#27755)
  Fix label render containing invalid HTML (go-gitea#27752)
  Fix duplicate project board when hitting `enter` key (go-gitea#27746)
  Fix `link-action` redirect network error (go-gitea#27734)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@silverwind @fuxiaohei
Upgrade to golangci-lint@v1.55.0 (go-gitea#27756)
50f3690 
https://github.com/golangci/golangci-lint/releases/tag/v1.55.0
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/internal size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @wxiaoguang @delvh @lunny @GiteaBot