Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect "tab" parameter for repo search sub-template #27755

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix incorrect "tab" parameter for repo search sub-template #27755

merged 2 commits into from
Oct 24, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 23, 2023 •
edited
Loading

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 23, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Oct 23, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Oct 23, 2023
@wxiaoguang wxiaoguang added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 23, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2023
@lunny lunny enabled auto-merge (squash) October 24, 2023 01:28
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 24, 2023
@lunny lunny merged commit def907d into go-gitea:main Oct 24, 2023
25 checks passed
@GiteaBot GiteaBot mentioned this pull request Oct 24, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 24, 2023
@wxiaoguang @GiteaBot
Fix incorrect "tab" parameter for repo search sub-template (go-gitea#…
b4fb29f 
…27755)

![image](https://github.com/go-gitea/gitea/assets/2114189/c546824e-4824-4f4d-bd33-e558c6ddf0ef)


![image](https://github.com/go-gitea/gitea/assets/2114189/713eb72c-22fb-412b-a867-9cccbf7548ec)
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 24, 2023
lunny pushed a commit that referenced this pull request Oct 24, 2023
@GiteaBot @wxiaoguang
Fix incorrect "tab" parameter for repo search sub-template (#27755) (#…
95db95e 
…27764)

Backport #27755 by wxiaoguang

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang deleted the fix-profile-tab branch October 24, 2023 03:02
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 24, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
356b2f4 
* giteaofficial/main:
  Do not force creation of _cargo-index repo on publish (go-gitea#27266)
  Upgrade to golangci-lint@v1.55.0 (go-gitea#27756)
  Fix incorrect "tab" parameter for repo search sub-template (go-gitea#27755)
  Fix label render containing invalid HTML (go-gitea#27752)
  Fix duplicate project board when hitting `enter` key (go-gitea#27746)
  Fix `link-action` redirect network error (go-gitea#27734)
@earl-warren earl-warren mentioned this pull request Oct 24, 2023
Closed
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Fix incorrect "tab" parameter for repo search sub-template (go-gitea#…
ee812e8 
…27755)

![image](https://github.com/go-gitea/gitea/assets/2114189/c546824e-4824-4f4d-bd33-e558c6ddf0ef)


![image](https://github.com/go-gitea/gitea/assets/2114189/713eb72c-22fb-412b-a867-9cccbf7548ec)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot