Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close all hashed buffers #27787

Merged
merged 3 commits into from Oct 25, 2023
Merged

Close all hashed buffers #27787

merged 3 commits into from Oct 25, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Oct 25, 2023

Add missing .Close() calls. The current code does not delete the temporary files if the data grows over 32mb.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 25, 2023
@silverwind silverwind added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2023
@KN4CK3R KN4CK3R merged commit ab3f6c1 into go-gitea:main Oct 25, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 25, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 25, 2023
Add missing `.Close()` calls. The current code does not delete the
temporary files if the data grows over 32mb.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 25, 2023
KN4CK3R added a commit that referenced this pull request Oct 25, 2023
Backport #27787 by @KN4CK3R

Add missing `.Close()` calls. The current code does not delete the
temporary files if the data grows over 32mb.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 26, 2023
* giteaofficial/main:
  Add link to members and repositories at teams page (go-gitea#27744)
  Add dedicated class for empty placeholders (go-gitea#27788)
  Close all hashed buffers (go-gitea#27787)
  Fix typo when updating email address (go-gitea#27789)
  Improve pull request command line instructions (go-gitea#27778)
@KN4CK3R KN4CK3R deleted the fix-close branch October 26, 2023 06:03
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
Add missing `.Close()` calls. The current code does not delete the
temporary files if the data grows over 32mb.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants