Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pull request command line instructions #27778

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

brechtvl
Copy link
Contributor

  • Show checkout instructions also when there is no permission to push, for anyone who wants to locally test the changes.
  • First checkout the branch exactly as is, without immediately having to solve merge conflicts. Leave this to the merge step, since it's often convenient to test a change without worrying about this.
  • Use git fetch -u, so an existing local branch is updated when re-testing the same pull request. But not the more risky git fetch -f in to handle force pushes, as we don't want to accidentally overwrite important local changes.
  • Show different merge command depending on the chosen merge style, interactively updated.

* Show checkout instructions also when there is no permission to push,
  for anyone who wants to locally test the changes.
* First checkout the branch exactly as is, without immediately having
  to solve merge conflicts. Leave this to the merge step, since it's
  often convenient to test a change without worrying about this.
* Use git fetch -u, so an existing local branch is updated when
  re-testing the same pull request (but not the more risky -f in
  to handle force pushes).
* Show different merge command depending on the chosen merge style.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 24, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 24, 2023
@brechtvl
Copy link
Contributor Author

Logged out or no ability to merge.
instructions_logged_out

Squash merge instructions now using --squash.
instructions_squash

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 25, 2023
@lunny lunny enabled auto-merge (squash) October 25, 2023 14:24
@lunny lunny merged commit 7a286e4 into go-gitea:main Oct 25, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 25, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 25, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 26, 2023
* giteaofficial/main:
  Add link to members and repositories at teams page (go-gitea#27744)
  Add dedicated class for empty placeholders (go-gitea#27788)
  Close all hashed buffers (go-gitea#27787)
  Fix typo when updating email address (go-gitea#27789)
  Improve pull request command line instructions (go-gitea#27778)
@Antonioya
Copy link

@brechtvl Is this change applied in Blender Gitea or is still pending?

@brechtvl
Copy link
Contributor Author

The Blender Gitea has not yet been updated to include this. Probably this or next week. (If you have further questions let's talk on Blender Chat.)

fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
* Show checkout instructions also when there is no permission to push,
for anyone who wants to locally test the changes.
* First checkout the branch exactly as is, without immediately having to
solve merge conflicts. Leave this to the merge step, since it's often
convenient to test a change without worrying about this.
* Use `git fetch -u`, so an existing local branch is updated when
re-testing the same pull request. But not the more risky `git fetch -f`
in to handle force pushes, as we don't want to accidentally overwrite
important local changes.
* Show different merge command depending on the chosen merge style,
interactively updated.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants