Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Notify reviewer added in pull request via codeowners file #28297

Closed
mg-cloud opened this issue Nov 29, 2023 · 1 comment · Fixed by #29842
Closed

[Enhancement] Notify reviewer added in pull request via codeowners file #28297

mg-cloud opened this issue Nov 29, 2023 · 1 comment · Fixed by #29842
Labels
type/bug
Milestone
1.21.9

Comments

@mg-cloud
Copy link

Feature Description

This could be an enhancement of #24910
This pull request added the neat codeowners feature to automatically add reviewer to pull request upon creation.
However, the reviewer are not notified by email unlike when added manually after the pull request is created.

I didn't find any discussion around that in the parent issue so i dunno if this was done on purpose or if this could be a nice enhancement of this feature.

Screenshots

No response
@mg-cloud mg-cloud added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Nov 29, 2023
@jpraet jpraet mentioned this issue Mar 16, 2024
Merged
lunny added a commit to jpraet/gitea that referenced this issue Mar 17, 2024
@lunny
Merge branch 'go-gitea#28297-notify-codeowners' of github.com:jpraet/…
2ead8a8 
…gitea into jpraet-go-gitea#28297-notify-codeowners
@lunny
Copy link
Member

lunny commented Mar 17, 2024

This should be considered as a bug but not a proposal.

@lunny lunny added the type/bug label Mar 17, 2024
@lunny lunny added this to the 1.21.9 milestone Mar 17, 2024
@lunny lunny removed the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Mar 17, 2024
lunny added a commit to jpraet/gitea that referenced this issue Mar 18, 2024
@lunny
Merge branch 'go-gitea#28297-notify-codeowners' of github.com:jpraet/…
8d28e50 
…gitea into jpraet-go-gitea#28297-notify-codeowners
lunny added a commit to jpraet/gitea that referenced this issue Mar 18, 2024
@lunny
Merge branch 'main' into jpraet-go-gitea#28297-notify-codeowners
e88cf6d
lunny added a commit to jpraet/gitea that referenced this issue Mar 19, 2024
@lunny
Merge branch 'main' into go-gitea#28297-notify-codeowners
1516565
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 28, 2024
@jpraet @Gusted
[Port] gitea#29842: Notify reviewers added via CODEOWNERS
003881b 
Fixes go-gitea/gitea#28297

This PR also fixed a problem that it needs a database transaction when
removing the WIP title.

---

Resolves #2771
Also partially ports gitea#29783

(cherry picked from commit 17d7ab5ad4ce3d0fbc1251572c22687c237a30b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.21.9
Development

Successfully merging a pull request may close this issue.

Notify reviewers added via CODEOWNERS jpraet/gitea
2 participants
@lunny @mg-cloud