Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show left arrow for compare #28522

Closed
kdumontnu opened this issue Dec 18, 2023 · 0 comments · Fixed by #28523
Closed

Show left arrow for compare #28522

kdumontnu opened this issue Dec 18, 2023 · 0 comments · Fixed by #28523
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@kdumontnu
Copy link
Contributor

Feature Description

For new users to git it can be confusing that comparison goes from right to left. This is probably why GitHub includes an arrow in their compare page. We should do the same.

Screenshots

GitHub:

image
@kdumontnu kdumontnu added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 18, 2023
@kdumontnu kdumontnu mentioned this issue Dec 19, 2023
Merged
lunny pushed a commit that referenced this issue Jan 5, 2024
@kdumontnu
Add merge arrow direction and update styling (#28523)
e522e77 
Close #28522

~Adds some [negative
margin](https://tailwindcss.com/docs/margin#using-negative-values)
helper css classes using tailwind's [prefix
syntax](https://tailwindcss.com/docs/configuration#prefix)~

### Before

![image](https://github.com/go-gitea/gitea/assets/12700993/5bdabf91-facd-41c8-8e36-e1535beb9409)

### After

![image](https://github.com/go-gitea/gitea/assets/12700993/a6f11f6f-9e64-45b6-b9d7-dfea53fbc6d7)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@kdumontnu @fuxiaohei
Add merge arrow direction and update styling (go-gitea#28523)
b2333df 
Close go-gitea#28522

~Adds some [negative
margin](https://tailwindcss.com/docs/margin#using-negative-values)
helper css classes using tailwind's [prefix
syntax](https://tailwindcss.com/docs/configuration#prefix)~

### Before

![image](https://github.com/go-gitea/gitea/assets/12700993/5bdabf91-facd-41c8-8e36-e1535beb9409)

### After

![image](https://github.com/go-gitea/gitea/assets/12700993/a6f11f6f-9e64-45b6-b9d7-dfea53fbc6d7)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@kdumontnu @silverwind
Add merge arrow direction and update styling (go-gitea#28523)
94a3ee6 
Close go-gitea#28522

~Adds some [negative
margin](https://tailwindcss.com/docs/margin#using-negative-values)
helper css classes using tailwind's [prefix
syntax](https://tailwindcss.com/docs/configuration#prefix)~

### Before

![image](https://github.com/go-gitea/gitea/assets/12700993/5bdabf91-facd-41c8-8e36-e1535beb9409)

### After

![image](https://github.com/go-gitea/gitea/assets/12700993/a6f11f6f-9e64-45b6-b9d7-dfea53fbc6d7)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add merge arrow direction and update styling AllSpiceIO/gitea
1 participant
@kdumontnu