Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull review state bug #28542

Closed
6543 opened this issue Dec 19, 2023 · 2 comments · Fixed by #28554
Closed

pull review state bug #28542

6543 opened this issue Dec 19, 2023 · 2 comments · Fixed by #28554
Assignees
@6543
Labels
type/bug
Milestone
1.21.6

Comments

@6543
Copy link
Member

6543 commented Dec 19, 2023

gitea: v1.21, v1.20, ... and older

reproduce: ( task | actor)

  1. pull to protected branch to USER_A | USER_B
  2. request review of USER_A | USER_B
  3. Review (ack/rej) | USER_A
  4. Push to pull change | USER_B
  5. Dismiss review | USER_A

-> review request can not be deleted
-> if "dismis stale reviews" is set, step 5. is not needed and gitea break it itself
@6543 6543 added the type/bug label Dec 19, 2023
@6543 6543 self-assigned this Dec 19, 2023
@6543
Copy link
Member Author

6543 commented Dec 19, 2023 •
edited
Loading

gitea/models/issues/review.go

Line 463 in 6a725b6

has, err := db.GetEngine(ctx).SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_id = ? AND original_author_id = 0 AND type in (?, ?, ?))",

gitea/models/issues/review.go

Line 482 in 6a725b6

if has, err = db.GetEngine(ctx).SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_team_id = ?)",

can we just use the xorm builder !!!!!!!

This was referenced Dec 20, 2023
Open
Merged
6543 added a commit that referenced this issue Feb 19, 2024
@6543
Workaround to clean up old reviews on creating a new one (#28554)
217d71c 
close  #28542

blocks  #28544

---
*Sponsored by Kithara Software GmbH*
@lunny lunny added this to the 1.21.6 milestone Feb 19, 2024
6543 added a commit to 6543-forks/gitea that referenced this issue Feb 19, 2024
@6543
Workaround to clean up old reviews on creating a new one (go-gitea#28554
79f0729 
)

close  go-gitea#28542

blocks  go-gitea#28544

---
*Sponsored by Kithara Software GmbH*
@6543 6543 mentioned this issue Feb 19, 2024
Merged
6543 added a commit that referenced this issue Feb 19, 2024
@6543
Workaround to clean up old reviews on creating a new one (#28554) (#2…
c01b266 
…9264)

close  #28542
backport #28554

---
*Sponsored by Kithara Software GmbH*
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@6543 @silverwind
Workaround to clean up old reviews on creating a new one (go-gitea#28554
a94bf6a 
)

close  go-gitea#28542

blocks  go-gitea#28544

---
*Sponsored by Kithara Software GmbH*
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@6543 6543

Labels
type/bug
Projects
None yet
Milestone
1.21.6
Development

Successfully merging a pull request may close this issue.

Workaround to clean up old reviews on creating a new one 6543-forks/gitea
2 participants
@lunny @6543