Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround to clean up old reviews on creating a new one (#28554) #29264

Merged
merged 3 commits into from Feb 19, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 19, 2024

close #28542
backport #28554


Sponsored by Kithara Software GmbH

@GiteaBot GiteaBot added this to the 1.21.6 milestone Feb 19, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 19, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2024
@6543 6543 added the pr/wip This PR is not ready for review label Feb 19, 2024
@6543
Copy link
Member Author

6543 commented Feb 19, 2024

looks like i have to adjust the test to the old codebase :/

@6543 6543 added type/bug and removed pr/wip This PR is not ready for review labels Feb 19, 2024
@6543 6543 requested a review from lafriks February 19, 2024 16:05
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2024
@6543 6543 enabled auto-merge (squash) February 19, 2024 16:21
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 19, 2024
@6543 6543 merged commit c01b266 into go-gitea:release/v1.21 Feb 19, 2024
27 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 19, 2024
@6543 6543 deleted the backport_28554 branch February 19, 2024 16:52
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants