Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught TypeError: e.getModifierState is not a function #29414

Closed
yp05327 opened this issue Feb 26, 2024 · 5 comments · Fixed by #29684
Closed

Uncaught TypeError: e.getModifierState is not a function #29414

yp05327 opened this issue Feb 26, 2024 · 5 comments · Fixed by #29684
Labels
type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there

Comments

@yp05327
Copy link
Contributor

yp05327 commented Feb 26, 2024

Description

image
I think this is not caused by browser extensions, as I have closed all of them that I could.

Reproduce:

  1. Open a repo, and click add new file.
  2. At the input box of filename, select LICENSE from the list:
    image

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@lng2020
Copy link
Member

lng2020 commented Feb 26, 2024 •
edited
Loading

I think it's microsoft/monaco-editor#4213 . As long as using Chrome auto-fill in this page, the error occurs.

@yp05327
Copy link
Contributor Author

yp05327 commented Feb 26, 2024 •
edited
Loading

I think microsoft/monaco-editor#4325 is more related and they are trying to fix it.

@silverwind silverwind added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label Feb 26, 2024
@silverwind
Copy link
Member

We could downgrade monaco if there is no workaround.

@Attacktive
Copy link

I downgraded to 0.44.0 and am happy with it.

@silverwind
Copy link
Member

Bug seems to not affect Firefox at least.

silverwind added a commit to silverwind/gitea that referenced this issue Mar 9, 2024
@silverwind
Downgrade monaco-editor and lock a few dependencies
9e2fcb1 
Fixes: go-gitea#29414
@silverwind silverwind mentioned this issue Mar 9, 2024
Merged
silverwind added a commit that referenced this issue Mar 9, 2024
@silverwind
Suppress error from monaco-editor (#29684)
9bf693d 
Fixes: #29414

I see no way for us to catch this error, so downgrade it until
microsoft/monaco-editor#4325 is fixed, which
will likely take a few weeks to propagate up from vscode.

The entries in `updates.config.js` will make
[`updates`](https://github.com/silverwind/updates) not upgrade these
anymore and I think it's good documentation as well to have the reasons
why we don't upgrade these dependencies.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 13, 2024
@silverwind @GiteaBot
Suppress error from monaco-editor (go-gitea#29684)
7ea49da 
Fixes: go-gitea#29414

I see no way for us to catch this error, so downgrade it until
microsoft/monaco-editor#4325 is fixed, which
will likely take a few weeks to propagate up from vscode.

The entries in `updates.config.js` will make
[`updates`](https://github.com/silverwind/updates) not upgrade these
anymore and I think it's good documentation as well to have the reasons
why we don't upgrade these dependencies.
@GiteaBot GiteaBot mentioned this issue Mar 13, 2024
Merged
6543 pushed a commit that referenced this issue Mar 13, 2024
@GiteaBot @silverwind
Suppress error from monaco-editor (#29684) (#29758)
462ae88 
Backport #29684 by @silverwind

Fixes: #29414

I see no way for us to catch this error, so downgrade it until
microsoft/monaco-editor#4325 is fixed, which
will likely take a few weeks to propagate up from vscode.

The entries in `updates.config.js` will make
[`updates`](https://github.com/silverwind/updates) not upgrade these
anymore and I think it's good documentation as well to have the reasons
why we don't upgrade these dependencies.

Co-authored-by: silverwind <me@silverwind.io>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 13, 2024
@silverwind @earl-warren
Suppress error from monaco-editor (#29684)
27beed7 
Fixes: go-gitea/gitea#29414

I see no way for us to catch this error, so downgrade it until
microsoft/monaco-editor#4325 is fixed, which
will likely take a few weeks to propagate up from vscode.

The entries in `updates.config.js` will make
[`updates`](https://github.com/silverwind/updates) not upgrade these
anymore and I think it's good documentation as well to have the reasons
why we don't upgrade these dependencies.

(cherry picked from commit 9bf693d98ddf8efa058a5fbbb6a3da5e0c12ab27)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 22, 2024
@GiteaBot @earl-warren
Suppress error from monaco-editor (#29684) (#29758)
73498c1 
Backport #29684 by @silverwind

Fixes: go-gitea/gitea#29414

I see no way for us to catch this error, so downgrade it until
microsoft/monaco-editor#4325 is fixed, which
will likely take a few weeks to propagate up from vscode.

The entries in `updates.config.js` will make
[`updates`](https://github.com/silverwind/updates) not upgrade these
anymore and I think it's good documentation as well to have the reasons
why we don't upgrade these dependencies.

Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit 462ae88fc2e6295a9376855627ad2a824a6c8f1d)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suppress error from monaco-editor silverwind/gitea
4 participants
@silverwind @yp05327 @Attacktive @lng2020