Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alphanumeric issue matching not working with quotes around issue #29484

Closed
hmoffatt opened this issue Feb 29, 2024 · 0 comments · Fixed by #29487
Closed

alphanumeric issue matching not working with quotes around issue #29484

hmoffatt opened this issue Feb 29, 2024 · 0 comments · Fixed by #29487
Labels
type/bug

Comments

@hmoffatt
Copy link

Description

I've enabled external issue tracking with an alphanumeric issue number format in my repository. The issue is linked correctly in commit messages, except when the ID is surrounded by a quote, as in git's automatic revert message format:

Revert "ABC-123 - add README"

See this on the demo site here: https://try.gitea.io/hmoffatt/hamish-test/commits/branch/main

Gitea Version

1.21.5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Firefox_Screenshot_2024-02-29T01-12-22 862Z

Git Version

No response

Operating System

Debian

How are you running Gitea?

Binary from your releases.

Database

PostgreSQL
charles7668 added a commit to charles7668/gitea that referenced this issue Feb 29, 2024
@charles7668
Fix issue link does not support quotes (go-gitea#29484)
a5a698f
@charles7668 charles7668 mentioned this issue Feb 29, 2024
Merged
charles7668 added a commit to charles7668/gitea that referenced this issue Feb 29, 2024
@charles7668
Fix issue link does not support quotes (go-gitea#29484)
952573f
charles7668 added a commit to charles7668/gitea that referenced this issue Mar 2, 2024
@charles7668
Fix issue AlphanumericPattern link does not support quotes (go-gitea#…
7e16b75 
…29484)
charles7668 added a commit to charles7668/gitea that referenced this issue Mar 2, 2024
@charles7668
Fix issue NumericPattern link does not support quotes (go-gitea#29484)
c21e01b
lunny pushed a commit that referenced this issue Mar 2, 2024
@charles7668
Fix issue link does not support quotes (#29484) (#29487)
9043584 
Close #29484

![圖片](https://github.com/go-gitea/gitea/assets/30816317/b27e6e16-67e0-469c-8e04-30180c585890)
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 2, 2024
@charles7668 @GiteaBot
Fix issue link does not support quotes (go-gitea#29484) (go-gitea#29487)
b44e000 
Close go-gitea#29484

![圖片](https://github.com/go-gitea/gitea/assets/30816317/b27e6e16-67e0-469c-8e04-30180c585890)
@GiteaBot GiteaBot mentioned this issue Mar 2, 2024
Merged
lunny pushed a commit that referenced this issue Mar 2, 2024
@GiteaBot @charles7668
Fix issue link does not support quotes (#29484) (#29487) (#29536)
3a8877c 
Backport #29487 by @charles7668

Close #29484

![圖片](https://github.com/go-gitea/gitea/assets/30816317/b27e6e16-67e0-469c-8e04-30180c585890)

Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>
zjjhot added a commit to zjjhot/gitea that referenced this issue Mar 2, 2024
@zjjhot
Merge remote-tracking branch 'upstream/main'
768e1ba 
* upstream/main:
  Fix a bug returning 404 when display a single tag with no release (go-gitea#29466)
  Add a check for when the command is canceled by the program on Window… (go-gitea#29538)
  Fix incorrect redirection when creating a PR fails (go-gitea#29537)
  Fix incorrect subpath in links (go-gitea#29535)
  Fix issue link does not support quotes (go-gitea#29484) (go-gitea#29487)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue link does not support quotes (#29484) charles7668/gitea
1 participant
@hmoffatt