Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The user profile follow button always shows "Follow", never "Unfollow" #29820

Closed
yardenshoham opened this issue Mar 15, 2024 · 3 comments · Fixed by #29865
Closed

The user profile follow button always shows "Follow", never "Unfollow" #29820

yardenshoham opened this issue Mar 15, 2024 · 3 comments · Fixed by #29865
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Milestone
1.22.0

Comments

@yardenshoham
Copy link
Member

yardenshoham commented Mar 15, 2024 •
edited

Description

To determine the string, the template looks at $.IsFollowing. See:

gitea/templates/shared/user/profile_big_avatar.tmpl

Line 120 in 6692894

{{if $.IsFollowing}}

Since #29248, the IsFollowing parameter is never set as the line that set it was deleted. The relevant diff

Gitea Version

Current main

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

demo

Git Version

No response

Operating System

No response

How are you running Gitea?

It doesn't matter

Database

SQLite
@yardenshoham yardenshoham added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Mar 15, 2024
@yardenshoham
Copy link
Member Author

CC @zokkis

@yardenshoham yardenshoham added this to the 1.22.0 milestone Mar 15, 2024
@yardenshoham yardenshoham mentioned this issue Mar 15, 2024
Merged
@silverwind
Copy link
Member

Definitely need to fix this before 1.22.

@lng2020
Copy link
Member

lng2020 commented Mar 17, 2024

It also breaks the user description on the profile page.
That PR is mainly focused on organization and accidentally deleted some code in the function PrepareContextForProfileBigAvatar that the user profile page also used.
So I guess just added those codes back in the function PrepareContextForProfileBigAvatar?

@lng2020 lng2020 mentioned this issue Mar 17, 2024
Merged
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 17, 2024
6543 pushed a commit that referenced this issue Mar 17, 2024
@lng2020
Fix missing code in the user profile (#29865)
5ca65d3 
fix #29820 
deleted by
https://github.com/go-gitea/gitea/pull/29248/files#diff-2b0b591787f16325539485e648a09ab6d3177f47dc129cfe84a35ffe141dfd19L39-L62,
which causing malfunction of follow/unfollow and missing description in
the user profile page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging a pull request may close this issue.

Fix missing code in the user profile lng2020/gitea
4 participants
@lunny @silverwind @yardenshoham @lng2020