Add default board to new projects, remove uncategorized pseudo-board #29874

denyskon · 2024-03-17T21:45:59Z

On creation of an empty project (no template) a default board will be created instead of falling back to the uneditable pseudo-board.

Every project now has to have exactly one default boards. As a consequence, you cannot unset a board as default, instead you have to set another board as default. Existing projects will be modified using a cron job, additionally this check will run every midnight by default.

Deleting the default board is not allowed, you have to set another board as default to do it.

Fixes #29873
Fixes #14679 along the way
Fixes #29853

Co-authored-by: delvh dev.lh@web.de

delvh · 2024-03-17T22:50:54Z

Wait, the default board is a pseudo-board?
Where is it set?

denyskon · 2024-03-18T04:54:10Z

@delvh

gitea/models/project/board.go

Line 258 in 16e3600

// represents a board for issues not assigned to one

denyskon · 2024-03-18T05:40:13Z

@lng2020 The default logic will apply if all columns are deleted which in fact can easily happen. Also, we cannot possibly do this change retroactively for all existing projects which currently display this default pseudo-column.

lunny

Do we really need the configuration? Maybe we can hardcode it and make it an option when we think it's necessary.

6543 · 2024-03-26T08:52:08Z

models/migrations/v1_22/v292.go

+// CheckProjectColumnsConsistency ensures there is exactly one default board per project present
+func CheckProjectColumnsConsistency(x *xorm.Engine) error {
+	var projects []project.Project
+	if err := x.SQL("SELECT DISTINCT `p`.`id`, `p`.`creator_id` FROM `project` `p` WHERE (SELECT COUNT(*) FROM `project_board` `pb` WHERE `pb`.`project_id` = `p`.`id` AND `pb`.`default` = ?) != 1", true).


I'd like to have pagination in this migration!

Honestly I have no idea what you mean or how to do it 🙈

Itterate over it in batches ... just look at older migrations

e.g.

gitea/models/migrations/v1_21/v276.go

Line 55 in 274bc00

limit := setting.Database.IterateBufferSize

Oh so the thing I did before 😆

Uh you did?

Yep, and then it was removed again.
Also, I don't quite see the benefit of batching here.
How does it help with anything?

I guess the only reason to batch is when amount of project boards is really massive and the SQL operation would risk running into timeouts maybe.

On the other hand, batched also brings the problem that the operation is not atomic, but if it's idempotent, it wouldn't matter when it's interrupted in the middle.

…tea into projects-default-board

Implemented

silverwind · 2024-03-27T18:59:29Z

@6543 looking good to you?

denyskon · 2024-03-27T20:55:47Z

Finally 🎉

* origin/main: (108 commits) Fix table alignment classes (go-gitea#30144) Add default board to new projects, remove uncategorized pseudo-board (go-gitea#29874) Fix loading spinner on ContextPopup (go-gitea#30145) Fix download buttons on branches page (go-gitea#30147) Relax generic package filename restrictions (go-gitea#30135) Remove jQuery class from the common admin functions (go-gitea#30137) Remove jQuery class from the reaction selector (go-gitea#30138) Forbid jQuery `.attr` (go-gitea#30116) Refactor render (go-gitea#30136) Fix: Organization Interface Display Issue (go-gitea#30133) Remove jQuery `.attr` from the Fomantic dropdowns (go-gitea#30114) Remove jQuery `.attr` from the common admin functions (go-gitea#30115) Remove jQuery from the create/rename branch modals (except Fomantic) (go-gitea#30109) Remove fomantic label module (go-gitea#30081) Fix bug for markdown rendering of blockquote (go-gitea#30130) Fix: The interface is broken when modifying code comments under mobile devices (go-gitea#30125) When the title in the issue has a value, set the text cursor at the end of the text. (go-gitea#30090) Load attachments for code comments (go-gitea#30124) Upgrade fabric to 6.0.0-beta20 (go-gitea#30121) Fix click handler in job-step-summary (go-gitea#30122) ...

wxiaoguang · 2024-03-28T02:11:06Z

models/migrations/v1_22/v292.go

+			Limit(limit, start).
+			Find(&projects); err != nil {
+			return err
+		}


Sorry but this migration seems broken ....

If the "SELECT" results are stable and never change, this for loop is right.

BUT, by each SELECT and for-loop, the "project boards" are changed. The next SELECT, it should still process the first page results, but not skip start.

For example: 150 projects.

First loop: SELECT gets 1-50 projects and updates them.

Second loop: SELECT gets "the second page" from "51-150", then it gets 101-150 projects.

Then the 51-100 projects are never migrated.

I will send a PR to fix it.

* giteaofficial/main: (63 commits) Apply to become a maintainer (go-gitea#30151) Refactor markdown render (go-gitea#30139) Drag-and-drop improvements for projects and issue pins (go-gitea#29875) Fix table alignment classes (go-gitea#30144) Add default board to new projects, remove uncategorized pseudo-board (go-gitea#29874) Fix loading spinner on ContextPopup (go-gitea#30145) Fix download buttons on branches page (go-gitea#30147) Relax generic package filename restrictions (go-gitea#30135) Remove jQuery class from the common admin functions (go-gitea#30137) Remove jQuery class from the reaction selector (go-gitea#30138) Forbid jQuery `.attr` (go-gitea#30116) Refactor render (go-gitea#30136) Fix: Organization Interface Display Issue (go-gitea#30133) Remove jQuery `.attr` from the Fomantic dropdowns (go-gitea#30114) Remove jQuery `.attr` from the common admin functions (go-gitea#30115) Remove jQuery from the create/rename branch modals (except Fomantic) (go-gitea#30109) Remove fomantic label module (go-gitea#30081) Fix bug for markdown rendering of blockquote (go-gitea#30130) Fix: The interface is broken when modifying code comments under mobile devices (go-gitea#30125) When the title in the issue has a value, set the text cursor at the end of the text. (go-gitea#30090) ... # Conflicts: # templates/user/dashboard/issues.tmpl

Fix #29874 (comment) - The migration of v292 will miss many projects. These projects will have no default board. This PR introduced a new migration number and removed v292 migration. - This PR also added the missed transactions on project-related operations. - Only `SetDefaultBoard` will remove duplicated defaults but not in `GetDefaultBoard`

Fix go-gitea/gitea#29874 (comment) - The migration of v292 will miss many projects. These projects will have no default board. This PR introduced a new migration number and removed v292 migration. - This PR also added the missed transactions on project-related operations. - Only `SetDefaultBoard` will remove duplicated defaults but not in `GetDefaultBoard` (cherry picked from commit 40cdc84b368cce8328b4b49ea5ecf1c5fa040300)

- as title - remove logic about zero `project_board_id` in `project_issue` table and fix some related test data. because after go-gitea#29874, `project_board_id` willn't be zero - some small refactoring Signed-off-by: a1012112796 <1012112796@qq.com>

set default board for new projects

efaa6ce

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 17, 2024

pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2024

denyskon requested a review from delvh March 17, 2024 21:46

github-actions bot added modifies/go Pull requests that update Go code modifies/docs labels Mar 17, 2024

denyskon added type/enhancement An improvement of existing functionality topic/projects labels Mar 17, 2024

denyskon added this to the 1.22.0 milestone Mar 17, 2024

delvh approved these changes Mar 17, 2024

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2024

This comment was marked as outdated.

Sign in to view

GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2024

denyskon mentioned this pull request Mar 18, 2024

Fix 500 when sorting the default project board #29870

Closed

Merge branch 'main' into projects-default-board

069687c

This comment was marked as outdated.

Sign in to view

lng2020 self-requested a review March 18, 2024 05:52

This comment was marked as outdated.

Sign in to view

rename uncategorized to backlog

b82fdbd

denyskon requested a review from lng2020 March 18, 2024 08:43

This comment was marked as outdated.

Sign in to view

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 18, 2024

Merge branch 'main' into projects-default-board

5c49766

lunny previously requested changes Mar 18, 2024

View reviewed changes

6543 previously requested changes Mar 26, 2024

View reviewed changes

GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 26, 2024

denyskon added 3 commits March 27, 2024 19:02

Merge remote-tracking branch 'upstream/main' into projects-default-board

aa06c97

add pagination

a3b5aa0

Merge branch 'projects-default-board' of ssh://github.com/denyskon/gi…

3ad1aa1

…tea into projects-default-board

denyskon requested a review from 6543 March 27, 2024 18:16

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 27, 2024

6543 approved these changes Mar 27, 2024

View reviewed changes

Merge branch 'main' into projects-default-board

a2baeff

6543 enabled auto-merge (squash) March 27, 2024 20:28

6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 27, 2024

6543 merged commit e516018 into go-gitea:main Mar 27, 2024
26 checks passed

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 27, 2024

denyskon deleted the projects-default-board branch March 27, 2024 20:55

wxiaoguang reviewed Mar 28, 2024

View reviewed changes

lunny mentioned this pull request Mar 28, 2024

Fix migration v292 #30153

Merged

a1012112796 mentioned this pull request Apr 25, 2024

create issue comment for project board move operation #30703

Open

lunny mentioned this pull request Apr 26, 2024

Wrong project_board_id for newly created issue #30701

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add default board to new projects, remove uncategorized pseudo-board #29874

Add default board to new projects, remove uncategorized pseudo-board #29874

denyskon commented Mar 17, 2024 •

edited

delvh commented Mar 17, 2024

denyskon commented Mar 18, 2024

This comment was marked as outdated.

denyskon commented Mar 18, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

lunny left a comment

6543 Mar 26, 2024

denyskon Mar 26, 2024

6543 Mar 26, 2024

6543 Mar 26, 2024

denyskon Mar 26, 2024

6543 Mar 26, 2024

delvh Mar 26, 2024

silverwind Mar 26, 2024 •

edited

denyskon Mar 27, 2024

silverwind commented Mar 27, 2024

denyskon commented Mar 27, 2024

wxiaoguang Mar 28, 2024 •

edited

lunny Mar 28, 2024

lunny Mar 28, 2024

Add default board to new projects, remove uncategorized pseudo-board #29874

Add default board to new projects, remove uncategorized pseudo-board #29874

Conversation

denyskon commented Mar 17, 2024 • edited

delvh commented Mar 17, 2024

denyskon commented Mar 18, 2024

This comment was marked as outdated.

denyskon commented Mar 18, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

lunny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

silverwind Mar 26, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

silverwind commented Mar 27, 2024

denyskon commented Mar 27, 2024

wxiaoguang Mar 28, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denyskon commented Mar 17, 2024 •

edited

silverwind Mar 26, 2024 •

edited

wxiaoguang Mar 28, 2024 •

edited