Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance optimization for git push #30104

Merged
merged 9 commits into from Apr 9, 2024
Merged

Performance optimization for git push #30104

merged 9 commits into from Apr 9, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 26, 2024

Agit returned result should be from ProcReceive hook but not PostReceive hook. Then for all non-agit pull requests, it will not check the pull requests for every pushing refs/pull/%d/head.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 26, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 26, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Mar 26, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 26, 2024
@lunny lunny added backport/v1.21 This PR should be backported to Gitea 1.21 type/bug labels Mar 27, 2024
wxiaoguang
wxiaoguang reviewed Mar 27, 2024
View reviewed changes
cmd/hook.go Outdated Show resolved Hide resolved
@wxiaoguang
Copy link
Contributor

No test?

@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label Mar 28, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2024
@lunny
Copy link
Member Author

lunny commented Mar 29, 2024

No test?

The original tests for agit have covered most of them except the returned link.

wxiaoguang
wxiaoguang reviewed Mar 31, 2024
View reviewed changes
modules/private/hook.go Outdated Show resolved Hide resolved
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 31, 2024 •
edited

No test?

The original tests for agit have covered most of them except the returned link.

What tests cover the logic of hook_post_receive.go:L193 ?

@lunny lunny mentioned this pull request Apr 3, 2024
Open
@lunny
Copy link
Member Author

lunny commented Apr 8, 2024

No test?

The original tests for agit have covered most of them except the returned link.

What tests cover the logic of hook_post_receive.go:L193 ?

Test added.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 9, 2024
@lunny lunny enabled auto-merge (squash) April 9, 2024 03:19
@lunny lunny merged commit 263a716 into go-gitea:main Apr 9, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 9, 2024
@GiteaBot
Copy link
Contributor

GiteaBot commented Apr 9, 2024

I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵

go run ./contrib/backport 30104
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 9, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 9, 2024
@lunny @GiteaBot
Performance optimization for git push (go-gitea#30104)
88ecd4e 
Agit returned result should be from `ProcReceive` hook but not
`PostReceive` hook. Then for all non-agit pull requests, it will not
check the pull requests for every pushing `refs/pull/%d/head`.
@GiteaBot GiteaBot mentioned this pull request Apr 9, 2024
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 9, 2024
@lunny lunny deleted the lunny/performance_agit branch April 9, 2024 03:51
silverwind pushed a commit that referenced this pull request Apr 9, 2024
@GiteaBot @lunny
Performance optimization for git push (#30104) (#30348)
82992cf 
Backport #30104 by @lunny

Agit returned result should be from `ProcReceive` hook but not
`PostReceive` hook. Then for all non-agit pull requests, it will not
check the pull requests for every pushing `refs/pull/%d/head`.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny added a commit that referenced this pull request Apr 9, 2024
@lunny
Performance optimization for git push (#30104)
4afec63 
Agit returned result should be from `ProcReceive` hook but not
`PostReceive` hook. Then for all non-agit pull requests, it will not
check the pull requests for every pushing `refs/pull/%d/head`.
@lunny lunny mentioned this pull request Apr 9, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Apr 9, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 10, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e1057cc 
* giteaofficial/main:
  Fix line height on inline code preview (go-gitea#30372)
  Refactor more filterslice (go-gitea#30370)
  Fix ambiguous id when fetch Actions tasks (go-gitea#30382)
  Fix floated list items (go-gitea#30377)
  Fix actions design about default actions download url (go-gitea#30360)
  Add container.FilterSlice function (go-gitea#30339)
  Fix label-list rendering in timeline, decrease gap (go-gitea#30342)
  Performance optimization for git push (go-gitea#30104)
  Reduce checkbox size to 15px (go-gitea#30346)
wolfogre pushed a commit that referenced this pull request Apr 10, 2024
@lunny
Performance optimization for git push (#30104) (#30354)
6e3aaa9 
Agit returned result should be from `ProcReceive` hook but not
`PostReceive` hook. Then for all non-agit pull requests, it will not
check the pull requests for every pushing `refs/pull/%d/head`.

Backport #30104
@wxiaoguang wxiaoguang added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Apr 19, 2024
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@silverwind silverwind silverwind approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @wxiaoguang @GiteaBot @silverwind @a1012112796