Fix line height on inline code preview #30372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
added
type/bug
backport/v1.22
wxiaoguang
approved these changes
Apr 10, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 10, 2024
GiteaBot
added
lgtm/done
lunny
added
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 10, 2024
Fixes go-gitea#30353. I don't know what causes `code-inner` to not inherit `line-height` from its direct parent `.lines-code` but instead from grandparent `.markup` even thought MDN tells me it's [inherited](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#formal_definition). This causes no negative impact on other code views, so I think it's the best solution.
GiteaBot
added
backport/done
silverwind
added a commit
that referenced
this pull request
Apr 10, 2024
Backport #30372 by @silverwind Fixes #30353. I don't know what causes `code-inner` to not inherit `line-height` from its direct parent `.lines-code` but instead from grandparent `.markup` even thought MDN tells me it's [inherited](https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#formal_definition). This causes no negative impact on other code views, so I think it's the best solution. Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 10, 2024
* giteaofficial/main: Fix line height on inline code preview (go-gitea#30372) Refactor more filterslice (go-gitea#30370) Fix ambiguous id when fetch Actions tasks (go-gitea#30382) Fix floated list items (go-gitea#30377) Fix actions design about default actions download url (go-gitea#30360) Add container.FilterSlice function (go-gitea#30339) Fix label-list rendering in timeline, decrease gap (go-gitea#30342) Performance optimization for git push (go-gitea#30104) Reduce checkbox size to 15px (go-gitea#30346)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30353.
I don't know what causes
code-innerto not inheritline-heightfrom its direct parent.lines-codebut instead from grandparent.markupeven thought MDN tells me it's inherited. This causes no negative impact on other code views, so I think it's the best solution.