Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for wiki routers #3022

Merged
merged 2 commits into from
Nov 30, 2017
Merged

Conversation

ethantkoenig
Copy link
Member

Unit tests for handlers for various wiki routes.

@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #3022 into master will increase coverage by 0.41%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3022      +/-   ##
=========================================
+ Coverage   32.98%   33.4%   +0.41%     
=========================================
  Files         270     270              
  Lines       39534   39555      +21     
=========================================
+ Hits        13042   13213     +171     
+ Misses      24637   24453     -184     
- Partials     1855    1889      +34
Impacted Files Coverage Δ
modules/test/context_tests.go 0% <0%> (ø) ⬆️
models/unit_tests.go 85% <78.94%> (-2.5%) ⬇️
models/error.go 32.82% <0%> (+1.84%) ⬆️
modules/indexer/repo.go 63.47% <0%> (+2.6%) ⬆️
models/repo_indexer.go 51.98% <0%> (+6.43%) ⬆️
models/wiki.go 63.3% <0%> (+10.79%) ⬆️
routers/repo/wiki.go 44.4% <0%> (+41.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab2b35...7d20ec8. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2017
@lafriks lafriks added this to the 1.4.0 milestone Nov 29, 2017
@lafriks
Copy link
Member

lafriks commented Nov 30, 2017

Some changes looks strange but LGTM :)

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 30, 2017
@lunny
Copy link
Member

lunny commented Nov 30, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2017
@lafriks
Copy link
Member

lafriks commented Nov 30, 2017

Make LG-TM work

@lafriks lafriks merged commit 91f3d77 into go-gitea:master Nov 30, 2017
@ethantkoenig ethantkoenig deleted the tests/wiki_routers branch December 18, 2017 06:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants