Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-admin user doesn't show repo dummy description #30502

Closed
wxiaoguang opened this issue Apr 15, 2024 · 4 comments · Fixed by #30552
Closed

Non-admin user doesn't show repo dummy description #30502

wxiaoguang opened this issue Apr 15, 2024 · 4 comments · Fixed by #30552
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 15, 2024 •
edited
Loading

(just to record, haven't looked into it, the UI looks pretty strange because there is a search input)

image

image
@wxiaoguang wxiaoguang changed the title Read-only user doesn't show repo description/topics Non-admin user doesn't show repo description/topics Apr 15, 2024
@wxiaoguang wxiaoguang changed the title Non-admin user doesn't show repo description/topics Non-admin user doesn't show repo dummy description Apr 15, 2024
@silverwind
Copy link
Member

I can reproduce. Somehow .Repository.DescriptionHTML is not set.

@silverwind silverwind added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Apr 15, 2024
@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label Apr 16, 2024
@yp05327
Copy link
Contributor

yp05327 commented Apr 16, 2024 •
edited
Loading

See this #2167

@silverwind
Copy link
Member

Thanks for digging that out. Seems a pointless change to me, I would revert it.

@yp05327
Copy link
Contributor

yp05327 commented Apr 17, 2024

About revert, see https://github.com/go-gitea/gitea/pull/3711/files#diff-7b2f4730100b2cf03a0e1d7cf7ca47d394b2a8db5ee7141f58643113026ea295R8
And it was revert in #5836

@wxiaoguang wxiaoguang mentioned this issue Apr 18, 2024
Merged
silverwind pushed a commit that referenced this issue Apr 21, 2024
@wxiaoguang
Fix repo home UI when there is no repo description (#30552)
f4a1cf7 
Fix #30502 by a new approach.


![image](https://github.com/go-gitea/gitea/assets/2114189/22f48bca-82d1-45cc-b1b7-ee2344b81a76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix repo home UI when there is no repo description wxiaoguang/gitea
3 participants
@silverwind @wxiaoguang @yp05327