Fix org owner cannot be removed if he is not in owner team

[lunny]

As title.

[codecov-io]

Codecov Report

Merging #3164 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #3164      +/-   ##
==========================================
- Coverage   34.75%   34.74%   -0.02%     
==========================================
  Files         276      276              
  Lines       39945    39949       +4     
==========================================
- Hits        13883    13879       -4     
- Misses      24069    24074       +5     
- Partials     1993     1996       +3

Impacted Files	Coverage Δ
models/org.go	68.55% <50%> (-0.39%)	⬇️
models/repo_indexer.go	50.97% <0%> (-0.98%)	⬇️
models/repo.go	41.28% <0%> (-0.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f033bf...753f1c6. Read the comment docs.

[ethantkoenig]

LGTM

[ethantkoenig]

What exactly is the difference between being an owner (i.e. OrgUser.IsOwner set to true) vs. being on the owner team? Do we need both, or can we combine the notions?

[lunny]

That should be a bug or something. The steps are:

1. create a new organization, then you will be owner of organization and also in owner team;
2. add another people to owner team;
3. leave the owner team.
   Then you will be an owner of organization but not in owner team.

[ethantkoenig]

@lunny I understand how to reproduce the bug, I'm just asking why we need the OrgUser.IsOwner field, as well as an owner team. My comment was not specific to this PR, but was just a general question/suggestion.

Would it make sense to get rid of the OrgUser.IsOwner field completely? What do we need it for?

[lunny]

@ethantkoenig this is a history problem. Old gitea version allow add member who are not in any team, but new version ask all org members be at least one team. I think it's time to get rid of the OrgUser.IsOwner field completely in v1.4.

[lafriks]

LGTM