-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TAGS
to TEST_TAGS
and fix bugs found with gogit
#31791
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAGS
to TEST_TAGS
TAGS
to TEST_TAGS
and fix bugs found with gogit
delvh
approved these changes
Aug 7, 2024
techknowlogick
approved these changes
Aug 7, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Aug 7, 2024
Found at go-gitea#31790 (comment) `unit-tests-gogit` never work since the workflow set `TAGS` with `gogit`, but the Makefile use `TEST_TAGS`. This PR adds the values of `TAGS` to `TEST_TAGS`, ensuring that setting `TAGS` is always acceptable and avoiding confusion about which one should be set.
wolfogre
added a commit
that referenced
this pull request
Aug 7, 2024
) Backport #31791 by @wolfogre Found at #31790 (comment) `unit-tests-gogit` never work since the workflow set `TAGS` with `gogit`, but the Makefile use `TEST_TAGS`. <img width="690" alt="image" src="https://github.com/user-attachments/assets/fb68df49-952b-42b9-8438-44200cefff43"> ![image](https://github.com/user-attachments/assets/78ff88c7-3b5f-4d50-9c58-e607bf7b1a71) This PR adds the values of `TAGS` to `TEST_TAGS`, ensuring that setting `TAGS` is always acceptable and avoiding confusion about which one should be set. After this PR: <img width="714" alt="image" src="https://github.com/user-attachments/assets/54cc7f38-d95b-4dbc-a87c-daba63462b86"> Co-authored-by: Jason Song <i@wolfogre.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 8, 2024
* giteaofficial/main: Add `TAGS` to `TEST_TAGS` and fix bugs found with gogit (go-gitea#31791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/done
All backports for this PR have been created
backport/v1.22
This PR should be backported to Gitea 1.22
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/go
Pull requests that update Go code
modifies/internal
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
type/bug
type/testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found at #31790 (comment)
unit-tests-gogit
never work since the workflow setTAGS
withgogit
, but the Makefile useTEST_TAGS
.This PR adds the values of
TAGS
toTEST_TAGS
, ensuring that settingTAGS
is always acceptable and avoiding confusion about which one should be set.After this PR: