Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing repository setting docs in cheat sheet #3230

Merged
merged 2 commits into from
Dec 19, 2017

Conversation

strk
Copy link
Member

@strk strk commented Dec 19, 2017

Taken from app.ini-sample

@strk
Copy link
Member Author

strk commented Dec 19, 2017

I started this to document PREFERRED_LICENSES but I don't really see that variable used in code, why was in app.ini-sample at all ?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 19, 2017
@codecov-io
Copy link

codecov-io commented Dec 19, 2017

Codecov Report

Merging #3230 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3230      +/-   ##
=========================================
+ Coverage   34.86%   34.9%   +0.04%     
=========================================
  Files         277     277              
  Lines       40014   40014              
=========================================
+ Hits        13951   13968      +17     
+ Misses      24040   24023      -17     
  Partials     2023    2023
Impacted Files Coverage Δ
models/repo.go 41.47% <0%> (+0.18%) ⬆️
models/repo_indexer.go 53.88% <0%> (+2.91%) ⬆️
modules/indexer/repo.go 67.82% <0%> (+6.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5332052...473399f. Read the comment docs.

@lafriks
Copy link
Member

lafriks commented Dec 19, 2017

@strk it is used in here:

for _, name := range setting.Repository.PreferredLicenses {

@lafriks
Copy link
Member

lafriks commented Dec 19, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 19, 2017
@sapk
Copy link
Member

sapk commented Dec 19, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 19, 2017
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Dec 19, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 19, 2017
@lunny lunny merged commit 7b28154 into go-gitea:master Dec 19, 2017
@strk strk deleted the repository-doc-cheat-sheet branch December 23, 2017 00:31
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants