Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query protected branch bug #3563

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Fix query protected branch bug #3563

merged 2 commits into from
Feb 23, 2018

Conversation

xwjdsh
Copy link
Contributor

@xwjdsh xwjdsh commented Feb 22, 2018

Signed-off-by: Wendell Sun iwendellsun@gmail.com

Fixes #3428

@xwjdsh
Fix query protected branch bug
db92e27 
Signed-off-by: Wendell Sun <iwendellsun@gmail.com>
@codecov-io
Copy link

codecov-io commented Feb 22, 2018 •
edited
Loading

Codecov Report

Merging #3563 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3563      +/-   ##
==========================================
- Coverage   35.78%   35.77%   -0.02%     
==========================================
  Files         285      285              
  Lines       40850    40850              
==========================================
- Hits        14620    14615       -5     
- Misses      24064    24067       +3     
- Partials     2166     2168       +2
Impacted Files Coverage Δ
models/branches.go 52.29% <100%> (ø) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 65.62% <0%> (-1.57%) ⬇️
models/repo_indexer.go 48.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845ba9d...8b10f7e. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 22, 2018
@lunny lunny added this to the 1.5.0 milestone Feb 23, 2018
@lunny
Copy link
Member

lunny commented Feb 23, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 23, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2018
@lunny lunny merged commit 19bf4dd into go-gitea:master Feb 23, 2018
@lafriks
Copy link
Member

lafriks commented Feb 23, 2018

@xwjdsh can you backport this to release/v1.4 branch?

xwjdsh added a commit to xwjdsh/gitea that referenced this pull request Feb 23, 2018
@xwjdsh
Fix query protected branch bug (go-gitea#3563)
9db40f9 
Signed-off-by: Wendell Sun <iwendellsun@gmail.com>
@xwjdsh xwjdsh mentioned this pull request Feb 23, 2018
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 23, 2018
lafriks pushed a commit that referenced this pull request Feb 23, 2018
@xwjdsh @lafriks
Fix query protected branch bug (#3563) (#3571)
dd78439 
Signed-off-by: Wendell Sun <iwendellsun@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Protecting a branch fails when branchname contains uppercase letters
6 participants
@xwjdsh @codecov-io @lunny @lafriks @appleboy @tboerger