Fix building of docs with latest hugo version #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
added
type/docs
Codecov Report
@@ Coverage Diff @@
## master #3856 +/- ##
=========================================
- Coverage 23.02% 23% -0.02%
=========================================
Files 126 126
Lines 24894 24892 -2
=========================================
- Hits 5731 5726 -5
- Misses 18287 18289 +2
- Partials 876 877 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
|
LGTM |
|
|
bkcsoft
added
lgtm/need 1
thehowl
reviewed
Apr 28, 2018
| @@ -28,6 +28,8 @@ for SOURCE in $(find ${ROOT}/content -type f -iname *.en-us.md); do | |||
| if [[ ! -f ${DEST} ]]; then | |||
| echo "Creating fallback for ${DEST#${ROOT}/content/}" | |||
| cp ${SOURCE} ${DEST} | |||
| sed -i.bak "s/en\-us/${LOCALE}/g" ${DEST} | |||
| rm ${DEST}.bak | |||
There was a problem hiding this comment.
why not a simple sed -i without .bak so that it modifies the file in place?
There was a problem hiding this comment.
Because on macosx sometimes it has problems by directly replacing in same file
|
alright then, LGTM. |
bkcsoft
added
lgtm/done
lafriks
added a commit
to lafriks-fork/gitea
that referenced
this pull request
Apr 29, 2018
lafriks
added a commit
that referenced
this pull request
Apr 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes latest CI failure because of using newer hugo version