-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building of docs with latest hugo version #3856
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3856 +/- ##
=========================================
- Coverage 23.02% 23% -0.02%
=========================================
Files 126 126
Lines 24894 24892 -2
=========================================
- Hits 5731 5726 -5
- Misses 18287 18289 +2
- Partials 876 877 +1
Continue to review full report at Codecov.
|
LGTM |
|
@@ -28,6 +28,8 @@ for SOURCE in $(find ${ROOT}/content -type f -iname *.en-us.md); do | |||
if [[ ! -f ${DEST} ]]; then | |||
echo "Creating fallback for ${DEST#${ROOT}/content/}" | |||
cp ${SOURCE} ${DEST} | |||
sed -i.bak "s/en\-us/${LOCALE}/g" ${DEST} | |||
rm ${DEST}.bak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not a simple sed -i
without .bak
so that it modifies the file in place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because on macosx sometimes it has problems by directly replacing in same file
alright then, LGTM. |
Fixes latest CI failure because of using newer hugo version