Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version of jQuery (1.11.3) #4384

Closed
kjellkvinge opened this issue Jul 6, 2018 · 7 comments · Fixed by #4551
Closed

Old version of jQuery (1.11.3) #4384

kjellkvinge opened this issue Jul 6, 2018 · 7 comments · Fixed by #4551
Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.
Milestone

Comments

@kjellkvinge
Copy link
Contributor

Ref gogs/gogs#5318

The 1.x branch is not supported anymore, but it should be possible to upgrade to 1.12.6 which is from may, 2016. 1.11.3 is from april 2015.

Would ut be possible to move to the supported 3.x branch?

@lafriks lafriks added type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed type/enhancement An improvement of existing functionality labels Jul 6, 2018
@ghost
Copy link

ghost commented Jul 6, 2018

Why not just bump the major?

@kjellkvinge
Copy link
Contributor Author

It's more work to migrate to 3.x. stuff might break and some (very old) browsers would not be supported. But moving to 3.x would stil be the best soullution IMHO.

https://jquery.com/upgrade-guide/3.0/

@thebrownfox
Copy link

Wouldn't be better to drop all of that instead of major or minor update?
You know, there is no need to support old browsers. This is kind of app that is used primarly by devs who use to have up to date sw. Also, you can support older browsers without jquery. I've noticed there is vuejs in gitea and the jquery is the last thing you want to do in that case. Let it die

@techknowlogick
Copy link
Member

Let's not assume that all devs have latest machines. This project has users with all kinds of resources, for example my laptop is as powerful as a rasperrypi, and some enterprises are still stuck on 32bit versions of windows 7.

That being said we have a baseline for browsers that we do support (the same baseline that semantic UI has).

It should also be noted that not all users of Gitea have JS enabled in their browser, and the FSF recommends that for ethical code hosting JS is not required: https://www.gnu.org/software/repo-criteria.en.html

I am supportive of moving to the latest in the 1.x branch of jQuery in hopes of eventually replacing all functionality that requires it with Vue.js.

@ghost
Copy link

ghost commented Jul 11, 2018

I am supportive of moving to the latest in the 1.x branch of jQuery in hopes of eventually replacing all functionality that requires it with Vue.js.

I'm happy to help on the Vue.js implementation when the time comes. And thanks for linking to the GNU website I was on it for about 2 hours yesterday reading about censorship and Microsoft Malware.

@ghost
Copy link

ghost commented Jul 17, 2018

Let's not assume that all devs have latest machines.

There's a difference between latest hardware and up-to-date software. The RPi is weak but it can still run the latest browsers.

@vintprox
Copy link

vintprox commented Jan 9, 2019

Vue is love 😁 I hope somebody will be able to figure out how to put Vue 3 (once it's released) in Gitea, which makes sense for unlabored frontend interface for plugins and stuff!

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants