Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs not show correct in rendered content for issue and wiki page #4813

Closed
2 tasks done
webjoel opened this issue Aug 28, 2018 · 9 comments · Fixed by #6445
Closed
2 tasks done

URLs not show correct in rendered content for issue and wiki page #4813

webjoel opened this issue Aug 28, 2018 · 9 comments · Fixed by #6445
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.8.0

Comments

@webjoel
Copy link
Contributor

webjoel commented Aug 28, 2018

Description

URLs not show correct in rendered content for issue and wiki page.

Screenshots

issue_comment
wiki
@lunny
Copy link
Member

lunny commented Aug 28, 2018 •
edited
Loading

It seems https://try.gitea.io/webjoel_test_user/test_url is blank.

@webjoel
Copy link
Contributor Author

webjoel commented Aug 28, 2018 •
edited
Loading

@lunny click in Issue page and wiki page. Not access?

@webjoel
Copy link
Contributor Author

webjoel commented Aug 28, 2018

Related to #2260 ?

@lunny
Copy link
Member

lunny commented Aug 29, 2018

I can see it in the wiki

@stale
Copy link

stale bot commented Jan 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 12, 2019
@webjoel
Copy link
Contributor Author

webjoel commented Jan 14, 2019

Not possible see problem?

https://try.gitea.io/webjoel_test_user/test_url/wiki/

@stale stale bot removed the issue/stale label Jan 14, 2019
@lunny lunny added the type/bug label Jan 25, 2019
@stale
Copy link

stale bot commented Mar 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 26, 2019
@webjoel
Copy link
Contributor Author

webjoel commented Mar 26, 2019

??

@stale stale bot removed the issue/stale label Mar 26, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Mar 26, 2019
@mrsdizzie
Copy link
Member

This happens because we run the sha1CurrentPattern processor first before the linkProcessor and wrongly picking up the numbers in https://stackoverflow.com/questions/44203982/why-is-android-o-failing-with-does-not-belong-to-this-fragmentmanageras a commit hash. The general linkProcessor should probably run after we look for specific links (full commit/issue/etc...) but before we start looking for more generic patterns. That would fix this particular issue.

Also sha1CurrentPattern is broken if it is hijacking that link above based on the numbers. It should probably only trigger if the patter exists on its own and not within another string. Will investigate/PR for this.

mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue Mar 27, 2019
@mrsdizzie
Change order that PostProcess Processors are run
923dc43 
Make sure Processors that work on full links are run first so that
something matching another pattern doesn't alter a link before we get to
it, for example:

 https://stackoverflow.com/questions/2896191/what-is-go-used-fore

Fixes go-gitea#4813
@mrsdizzie mrsdizzie mentioned this issue Mar 27, 2019
Merged
techknowlogick pushed a commit that referenced this issue Mar 27, 2019
@mrsdizzie @techknowlogick
Change order that PostProcess Processors are run (#6445)
c8650ae 
Make sure Processors that work on full links are run first so that
something matching another pattern doesn't alter a link before we get to
it, for example:

 https://stackoverflow.com/questions/2896191/what-is-go-used-fore

Fixes #4813
mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue Mar 27, 2019
@mrsdizzie
Change order that PostProcess Processors are run (go-gitea#6445)
0a4a5e3 
Make sure Processors that work on full links are run first so that
something matching another pattern doesn't alter a link before we get to
it, for example:

 https://stackoverflow.com/questions/2896191/what-is-go-used-fore

Fixes go-gitea#4813
@mrsdizzie mrsdizzie mentioned this issue Mar 27, 2019
Merged
@techknowlogick techknowlogick added this to the 1.8.0 milestone Mar 27, 2019
techknowlogick pushed a commit that referenced this issue Mar 27, 2019
@mrsdizzie @techknowlogick
Change order that PostProcess Processors are run (#6445) (#6447)
4a0f7c1 
Make sure Processors that work on full links are run first so that
something matching another pattern doesn't alter a link before we get to
it, for example:

 https://stackoverflow.com/questions/2896191/what-is-go-used-fore

Fixes #4813
@nodiscc nodiscc mentioned this issue Apr 9, 2019
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Change order that PostProcess Processors are run mrsdizzie/gitea
4 participants
@lunny @techknowlogick @mrsdizzie @webjoel