Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Clarity for HTTPS setups #5626

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Documentation: Clarity for HTTPS setups #5626

merged 1 commit into from
Jan 3, 2019
+16 −3

Conversation

0x5c
Copy link
Contributor

@0x5c 0x5c commented Jan 3, 2019

[https-setup]

  • Made it clearer that HTTP redirection is possible
    [config-cheat-sheet]
  • Clarified the behaviour of the redirection-related config keys

@0x5c
Documentation: Clarity for HTTPS setups
eb72347 
[https-setup]
- Made it clearer that HTTP redirection is possible
[config-cheat-sheet]
- Clarified the behavihour of the redirection-related config keys
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@9863591). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5626   +/-   ##
=========================================
  Coverage          ?   37.83%           
=========================================
  Files             ?      322           
  Lines             ?    47474           
  Branches          ?        0           
=========================================
  Hits              ?    17962           
  Misses            ?    26928           
  Partials          ?     2584

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9863591...eb72347. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 3, 2019
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Jan 3, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 3, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 3, 2019
@jonasfranz jonasfranz merged commit 0de57fd into go-gitea:master Jan 3, 2019
techknowlogick pushed a commit that referenced this pull request Jan 3, 2019
@0x5c @techknowlogick
Documentation: Clarity for HTTPS setups (#5626)
b5f4911 
[https-setup]
- Made it clearer that HTTP redirection is possible
[config-cheat-sheet]
- Clarified the behavihour of the redirection-related config keys

Signed-off-by: Matti Ranta <matti@mdranta.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@0x5c @codecov-io @techknowlogick @jonasfranz @lunny @bkcsoft