New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Clarity for HTTPS setups #5626

Merged
merged 1 commit into from Jan 3, 2019

Conversation

6 participants
@0x5c
Copy link
Contributor

0x5c commented Jan 3, 2019

[https-setup]

  • Made it clearer that HTTP redirection is possible
    [config-cheat-sheet]
  • Clarified the behaviour of the redirection-related config keys
Documentation: Clarity for HTTPS setups
[https-setup]
- Made it clearer that HTTP redirection is possible
[config-cheat-sheet]
- Clarified the behavihour of the redirection-related config keys
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 3, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@9863591). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5626   +/-   ##
=========================================
  Coverage          ?   37.83%           
=========================================
  Files             ?      322           
  Lines             ?    47474           
  Branches          ?        0           
=========================================
  Hits              ?    17962           
  Misses            ?    26928           
  Partials          ?     2584

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9863591...eb72347. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Jan 3, 2019

@lunny lunny added the kind/docs label Jan 3, 2019

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Jan 3, 2019

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jan 3, 2019

@jonasfranz jonasfranz merged commit 0de57fd into go-gitea:master Jan 3, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

techknowlogick added a commit that referenced this pull request Jan 3, 2019

Documentation: Clarity for HTTPS setups (#5626)
[https-setup]
- Made it clearer that HTTP redirection is possible
[config-cheat-sheet]
- Clarified the behavihour of the redirection-related config keys

Signed-off-by: Matti Ranta <matti@mdranta.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment