Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to disable automatic repo watching #5852

Merged
merged 5 commits into from
Jan 27, 2019
Merged

Config option to disable automatic repo watching #5852

merged 5 commits into from
Jan 27, 2019

Conversation

sebastian-sauer
Copy link
Contributor

@sebastian-sauer sebastian-sauer commented Jan 25, 2019

Add a new config option AUTO_WATCH_NEW_REPOS to enable / disable the automatic watching of
repos for new repositories and if a user is added to a team.

This could fix #653

Add a new config option to enable / disable the automatic watching of
repos for new repositories and if a user is added to a team.

Signed-off-by: Sebastian Sauer <sauer.sebastian@gmail.com>
@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #5852 into master will decrease coverage by 0.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5852      +/-   ##
==========================================
- Coverage   37.85%   37.84%   -0.02%     
==========================================
  Files         328      328              
  Lines       48318    48323       +5     
==========================================
- Hits        18292    18289       -3     
- Misses      27395    27404       +9     
+ Partials     2631     2630       -1
Impacted Files Coverage Δ
modules/setting/setting.go 49.37% <100%> (+0.06%) ⬆️
models/org_team.go 50% <16.66%> (ø) ⬆️
models/repo.go 43.85% <20%> (ø) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 46.1% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a81cb...561a30f. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 25, 2019
@lafriks
Copy link
Member

lafriks commented Jan 25, 2019

It would be great if that could be added also as per-user option

Copy link
Member

@adelowo adelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Sebastian Sauer <sauer.sebastian@gmail.com>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2019
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Jan 26, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 26, 2019
@zeripath zeripath merged commit 8407621 into go-gitea:master Jan 27, 2019
@kolaente
Copy link
Member

kolaente commented Jan 27, 2019

Mssql test failed when merging to master, can someone restart the build?

bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
Add a new config option to enable / disable the automatic watching of
repos for new repositories and if a user is added to a team.

Fixes go-gitea#653

Signed-off-by: Sebastian Sauer <sauer.sebastian@gmail.com>
@trepmag
Copy link

trepmag commented Jan 21, 2020

Hello, I tested the variable set to AUTO_WATCH_NEW_REPOS=false as follow:

  • when adding a user to the Owner team of an Organization related repositories are being watch by this user
  • when creating a repository that repository is getting watch by all user set in the related Organization Owner team

Is thoses use cases are intent to be covered by those use cases?

This was observed with 1.10.3

Update

sorry, it works; I was setting this variable as environment one but is must be set in app.ini; see https://docs.gitea.io/en-us/config-cheat-sheet/

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Owner team automatically watching new repo's
9 participants