UI: Repo header tweaks #5945
Merged
UI: Repo header tweaks #5945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5945 +/- ##
========================================
Coverage ? 38.7%
========================================
Files ? 330
Lines ? 48642
Branches ? 0
========================================
Hits ? 18825
Misses ? 27090
Partials ? 2727Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
- Use basic buttons on the header buttons, matching gogs - Make 'Manage topic' text smaller, remove margin-left with no topics present - Move various inline styles to CSS - Use flexbox on header title and buttons
adelowo
reviewed
Feb 3, 2019
public/less/_repository.less
Outdated
| @media only screen and (max-width: 768px) { | ||
| width: 100%; | ||
| } | ||
| @media only screen and (max-width: 768px) { |
There was a problem hiding this comment.
This formatting looks a little off
There was a problem hiding this comment.
It isn't really off, just made it consistent to 4-space indent. But now that I look at it, I'm not sure this will even work, you usually wrap selectors inside a media query, not the other way around, fixing that.
|
After screenshot updated, now centered |
techknowlogick
approved these changes
Feb 5, 2019
GiteaBot
added
lgtm/need 1
zeripath
approved these changes
Feb 5, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
present
Before
After
Note: The missing icon on the watch button is not related to this commit, some kind of font cache issue on my side.