Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue closure with empty comment does not generate E-Mail #5977

Closed
silverwind opened this issue Feb 6, 2019 · 3 comments · Fixed by #7165
Closed

Issue closure with empty comment does not generate E-Mail #5977

silverwind opened this issue Feb 6, 2019 · 3 comments · Fixed by #7165
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@silverwind
Copy link
Member

Gitea version (or commit ref): 0c721fe

When a issue is closed with a empty comment box, no E-Mail seems to be sent to watchers.
@lunny lunny added the type/bug label Feb 7, 2019
@stale
Copy link

stale bot commented Apr 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 8, 2019
@stale
Copy link

stale bot commented Apr 22, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Apr 22, 2019
@silverwind silverwind mentioned this issue Jun 9, 2019
Closed
@techknowlogick techknowlogick reopened this Jun 9, 2019
@techknowlogick techknowlogick added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jun 9, 2019
@silverwind
Copy link
Member Author

silverwind commented Jun 9, 2019 •
edited
Loading

There's actually two issues here:

  1. Closing a issue without a comment does not send a mail
  2. Closing a issue with comment sends a mail but only with the Closed #id text

First case should send 1 mail, second case should actually send 2 mails.

@silverwind silverwind mentioned this issue Jun 9, 2019
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Jun 9, 2019
@silverwind
Various fixes for issue mail notifications
59d4674 
- Send individual mails for actions and comments
- Send mail for new issues/prs without a comment
- Use correct sender for reopen/close actions
- Hopefully fixed all bugs related to missing mails

Fixes: go-gitea#7124
Fixes: go-gitea#5977
zeripath pushed a commit that referenced this issue Jun 11, 2019
@silverwind @zeripath
Various fixes for issue mail notifications (#7165)
499a8a1 
- Send individual mails for actions and comments
- Send mail for new issues/prs without a comment
- Use correct sender for reopen/close actions
- Hopefully fixed all bugs related to missing mails

Fixes: #7124
Fixes: #5977
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this issue Jul 18, 2019
@silverwind @jeffliu27
Various fixes for issue mail notifications (go-gitea#7165)
e19f5dd 
- Send individual mails for actions and comments
- Send mail for new issues/prs without a comment
- Use correct sender for reopen/close actions
- Hopefully fixed all bugs related to missing mails

Fixes: go-gitea#7124
Fixes: go-gitea#5977
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Various fixes for issue mail notifications silverwind/gitea
3 participants
@lunny @silverwind @techknowlogick