Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single line per selector & don't strip license comments #6919

Merged
merged 1 commit into from
May 13, 2019

Conversation

xf-
Copy link
Contributor

@xf- xf- commented May 12, 2019

Why?
Every PR touching css needs a rebase after a single change in an merged PR. Single line will only conflict if the same line/area is modified. Less Builds, less conflicts

Also i added -s0 option. No comments with ?*! will be removed (used for licenses).

I also would like the source map option, but isn't in code like all other options.

Doku
https://github.com/jakubpawlowicz/clean-css/tree/v3.0.1#how-to-use-clean-css-cli

@lafriks
Copy link
Member

lafriks commented May 12, 2019

What is the size difference?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 12, 2019
@xf-
Copy link
Contributor Author

xf- commented May 12, 2019

With line-breaks:

Filesystem:
98.8KB index.css
20.1KB theme-arc-green.css

Transfered
16.46KB (gzip level 6)
image

15.07KB (brotli standard level)
image

Without line breaks

Filesystem:
94.8KB index.css
19.8KB theme-arc-green.css

Transfered
16.41KB (gzip level 6)
image

15.03KB (brotli standard level)
image

@codecov-io
Copy link

codecov-io commented May 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5df5bfb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6919   +/-   ##
=========================================
  Coverage          ?   41.41%           
=========================================
  Files             ?      441           
  Lines             ?    59736           
  Branches          ?        0           
=========================================
  Hits              ?    24738           
  Misses            ?    31760           
  Partials          ?     3238

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df5bfb...47cc9d0. Read the comment docs.

@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label May 12, 2019
@xf-
Copy link
Contributor Author

xf- commented May 12, 2019

About few bytes. could be saved by removing some insane nesting like .repository.file.list .non-diff-file-content .code-view .lines-commit .blame-info .blame-data .blame-message. This also allows for a better code review. no 1 line sting.

Normally a linter is used to avoid stuff like this and get an more consistent less/sass file.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 12, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2019
@zeripath zeripath merged commit 06ae9a3 into go-gitea:master May 13, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants