Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plain text overflow line wrap #6915

Merged
merged 3 commits into from
May 14, 2019
Merged

Conversation

xf-
Copy link
Contributor

@xf- xf- commented May 11, 2019

Fix #5698

pre-wrap supports still ascii art or other multiple indents, but breaks before line is full and overflow is in use.

image

@codecov-io
Copy link

codecov-io commented May 12, 2019

Codecov Report

Merging #6915 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6915      +/-   ##
==========================================
+ Coverage   41.39%   41.39%   +<.01%     
==========================================
  Files         441      441              
  Lines       59733    59733              
==========================================
+ Hits        24728    24729       +1     
+ Misses      31766    31765       -1     
  Partials     3239     3239
Impacted Files Coverage Δ
modules/log/colors_router.go 83.33% <0%> (-4.17%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 43.03% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6123840...0227c50. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 12, 2019
@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels May 12, 2019
@lafriks lafriks added this to the 1.9.0 milestone May 12, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 12, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 12, 2019
@lafriks
Copy link
Member

lafriks commented May 12, 2019

Please rebaset this one first

@xf-
Copy link
Contributor Author

xf- commented May 12, 2019

@lafriks what do you think about #6919
Would make a lot of rebases obsolete

@xf-
Copy link
Contributor Author

xf- commented May 13, 2019

@lafriks done

@techknowlogick techknowlogick merged commit 0e057eb into go-gitea:master May 14, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] File-view box overflows text
7 participants