Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing description of label on API #7159

Merged
merged 5 commits into from
Jun 16, 2019
Merged

Add missing description of label on API #7159

merged 5 commits into from
Jun 16, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 8, 2019

As title.

@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 8, 2019
techknowlogick
techknowlogick reviewed Jun 8, 2019
View reviewed changes
modules/structs/issue_label.go Outdated
@@ -1,4 +1,5 @@
// Copyright 2016 The Gogs Authors. All rights reserved.
// Copyright 2019 The Gogs Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitea

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 8, 2019
@codecov-io
Copy link

codecov-io commented Jun 10, 2019 •
edited

Codecov Report

Merging #7159 into master will decrease coverage by <.01%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7159      +/-   ##
==========================================
- Coverage   41.53%   41.53%   -0.01%     
==========================================
  Files         449      449              
  Lines       61338    61343       +5     
==========================================
- Hits        25479    25478       -1     
- Misses      32503    32510       +7     
+ Partials     3356     3355       -1
Impacted Files Coverage Δ
routers/api/v1/repo/label.go 0% <0%> (ø) ⬆️
models/issue_label.go 62.26% <100%> (+0.14%) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367aeb1...3bd85a9. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 10, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 16, 2019
@lunny lunny merged commit d8168b3 into go-gitea:master Jun 16, 2019
@lunny lunny deleted the lunny/add_label_description branch June 16, 2019 12:40
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 17, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Add missing description of label on API (go-gitea#7159)
6d9378e 
* add missing description of label on API

* fix comment head

* fix swagger
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@zeripath zeripath zeripath approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @codecov-io @techknowlogick @zeripath @adelowo @GiteaBot