Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mssql driver to last working version 20180314172330-6a30f4e59a44 #7306

Merged
merged 6 commits into from
Jun 30, 2019

Conversation

sapk
Copy link
Member

@sapk sapk commented Jun 26, 2019

Following investigation done in #7294, I found the last version working of mssql driver. In the meantime, that we found why the next commit fail we can still update the mssql driver.

Changelog: denisenkom/go-mssqldb@e32ca50...6a30f4e

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 26, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2019
@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@aeb8f7a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7306   +/-   ##
=========================================
  Coverage          ?   41.24%           
=========================================
  Files             ?      464           
  Lines             ?    63107           
  Branches          ?        0           
=========================================
  Hits              ?    26031           
  Misses            ?    33670           
  Partials          ?     3406

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb8f7a...512b4eb. Read the comment docs.

@sapk sapk mentioned this pull request Jun 27, 2019
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jun 30, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 30, 2019
@lunny lunny merged commit 1e46eed into go-gitea:master Jun 30, 2019
@sapk sapk deleted the updt-mssql-driver branch June 30, 2019 09:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants