-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] mod: update locked down go-mssqldb to old version #7294
Conversation
I will investigate why the database is not cleared for tests. |
Codecov Report
@@ Coverage Diff @@
## master #7294 +/- ##
==========================================
+ Coverage 41.15% 41.16% +<.01%
==========================================
Files 464 464
Lines 62763 62763
==========================================
+ Hits 25833 25834 +1
+ Misses 33537 33535 -2
- Partials 3393 3394 +1
Continue to review full report at Codecov.
|
Yes doing so I remember also playing with it previously. I will try to narrow done the exact commit that fail. |
Seems to be a commit between denisenkom/go-mssqldb@94099f0...9340cdc |
We will need to wait for the last test to confirm but it should be denisenkom/go-mssqldb@9340cdc that is blocking. |
@sapk is it only the migration test that's failing? It might just be easier to fix the migration test surely? |
@zeripath It is the first step (remove of old database) that fail silently so all subsequent call fail. I don't know if it impact later other things as I don't know why the delete hasn't work (and the command return successful). |
mssql driver was locked down to an old version.
I suspect because of xorm not using go.mod previously and that we haven't mssql test integration also.
But now, both are fixed.
Compare link: denisenkom/go-mssqldb@e32ca50...b04fd42