URL to tag goes to branch if they have the same name

[davidsvantesson]

• Gitea version (or commit ref): 1.10.0+dev-198-g111d31d68
• Git version:
• Operating system:
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

When a branch and a tag has the same name, entering the URL to the tag shows the branch instead.

Example: https://try.gitea.io/merle_noir/TestName/src/tag/BranchAndTagNameSame is URL to tag but it shows the content of the branch with the same name.

[lunny]

What do you think the proper behaviour?

[davidsvantesson]

Expected behavior:

• {Repo}/src/branch/{refname}: 404 if branch {refname} doesn't exist. If exist show branch.
• {Repo}/src/tag/{refname}: 404 if tag {refname} doesn't exist. If exist show tag.

Actual behavior:

• {Repo}/src/branch/{refname}: 404 if branch {refname} doesn't exist. If exist show branch.
• {Repo}/src/tag/{refname}: 404 if tag {refname} doesn't exist. If exist show branch (in first case, if it exist) otherwise show tag.

The reason for this is in /modules/context/repo.go, func RepoRefByType, the code first correctly determines if the branch or tag exist (depending on what is requested), but then first check if branch exist (line 610) regardless if branch or tag was requested.